Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MavenPomDownloader constructors #5104

Open
knutwannheden opened this issue Feb 27, 2025 · 1 comment
Open

Deprecate MavenPomDownloader constructors #5104

knutwannheden opened this issue Feb 27, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@knutwannheden
Copy link
Contributor

The current MavenPomDownloader constructors are a bit confusing, especially since one of them is specific to Gradle and the others are intended to be used for Maven. (The difference being that in the Gradle case Maven Central and Maven Local should not be automatically added as repos.)

There are various ways to improve this. The simplest thing would be to make the constructors private and provide factory methods with "Maven" and "Gradle" in their names. There are probably other better options.

@knutwannheden knutwannheden added the enhancement New feature or request label Feb 27, 2025
@shanman190
Copy link
Contributor

Another option would be to have the Maven marker carry all repositories, including any default ones like Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants