Xml.Tag should provide a method to read a specific attribute value

[bmuschko]

What problem are you trying to solve?

I am reading information from a Xml.Tag via the XmlIsoVisitor.visitTag method. I have to read the value of a specific attribute.

Right now, this is harder than it needs to be.

List<Xml.Attribute> attributes = tag.getAttributes();
String attributeValue = getAttributeValue(attributes, "myattribute");

private String getAttributeValue(List<Xml.Attribute> attributes, String attributeName) {
    Optional<Xml.Attribute> attribute = attributes.stream().filter(a -> attributeName.equals(a.getKeyAsString())).findFirst();
    return attribute.map(Xml.Attribute::getValueAsString).orElse(null);
}

Describe the solution you'd like

I'd like to see a convenience method that does something similar to getAttributeValue. Is this something you'd consider?

Have you considered any alternatives or workarounds?

Yes, see method above.

Additional context

N/A

Are you interested in [contributing this feature to OpenRewrite]

Yes

[timtebeek]

Thanks for the suggestion! This still seems reasonable to me. As a bit of context we tend to have the LST elements merely represent the underlying structure, while we use higher level constructs like visitors and traits to make it easier to manipulate the underlying elements. That then also means there's less of a need to evolve the LST elements, which helps backwards compatibility with our serialization. Not sure how that work out exactly in this case, but perhaps it's good to explore two or more options briefly.