Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExplicitCharsetOnStringGetBytes should use "UTF_8" instead of "<error>" #5

Open
koppor opened this issue Apr 30, 2023 · 1 comment
Open

ExplicitCharsetOnStringGetBytes should use "UTF_8" instead of "<error>" #5

koppor opened this issue Apr 30, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@koppor
Copy link
Contributor

koppor commented Apr 30, 2023 •
edited
Loading

I experience the output of ´StandardCharsets.` and I don't know why.

Old:

- metaList.add(XmpUtilShared.parseXmpMetadata(new ByteArrayInputStream(xmpMetaString.getBytes())));
+ metaList.add(XmpUtilShared.parseXmpMetadata(new ByteArrayInputStream(xmpMetaString.getBytes(StandardCharsets.<error>))));

https://github.com/JabRef/jabref/blob/913b46cf0c31a4f7f73c84e4a8584c9adb8c701f/src/main/java/org/jabref/logic/xmp/XmpUtilReader.java#L130
@koppor koppor mentioned this issue Apr 30, 2023
Closed
@timtebeek timtebeek transferred this issue from openrewrite/rewrite May 1, 2023
@timtebeek timtebeek added the bug Something isn't working label May 1, 2023
@timtebeek timtebeek moved this to Backlog in OpenRewrite May 1, 2023
@rpau rpau added this to the Good first experience with static code analysis recipes milestone May 30, 2023
@timtebeek timtebeek removed this from the Good first experience with static code analysis recipes milestone Nov 30, 2023
@koppor
Copy link
Contributor Author

koppor commented Jul 1, 2024

It could be because of openrewrite/rewrite#4054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
OpenRewrite
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timtebeek @koppor @rpau