-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can Nexradlevel2 reader read streamed data? #265
Comments
@aladinor Thanks for splitting this out. Thanks @ghiggi for raising this. I'd strongly vote against doing something like this. Instead we should advertise users how to do this with boilerplate code. Things work for |
Hi @kmuehlbauer, Thanks for pointing that out. I totally agree that we should avoid loading the full file into memory and rely on It seems like using Since most NEXRAD data is stored in S3, it might be worth considering an optional streaming implementation. Please let me know your thoughts |
So "support streaming" should just mean "can read streamed data"? Then we might just adapt this feature from IRIS to NEXRAD to make this happen. What I'm voting against is to use gz/s3fs/fsspec/etc inside our implementation. |
Hi @kmuehlbauer, Thanks for the clarification, and my apologies for the confusion—that was entirely my misunderstanding! You're absolutely right. By "support streaming," we’re aiming for the ability to read streamed data, not necessarily to integrate gz, s3fs, or fsspec directly into the core implementation. Given that, adapting the streaming capabilities from the IRIS reader for NEXRAD sounds like a great idea. I’ll take a closer look at how we can make that happen without adding unnecessary dependencies. Thanks again for your patience and guidance on this! |
@aladinor Great! These additions to the first IRIS reader have been made when it still was a part of wradlib. I can look up the commits and link them here, if necessary. |
Hi @kmuehlbauer, That sounds awesome! I'd be happy to work on adapting the IRIS streaming feature for NEXRAD. If you could link those commits, it would definitely be helpful as a reference! |
@aladinor These are the relevant wradlib PR's:
|
Hi guys ! I just wanted to mention that we could eventually adding the capability to directly read compressed formats and open files from S3 paths into the Right now, when the |
Thanks @ghiggi for letting us know. That behaviour is another indication that xradar should not put too much magic into file readers, but let the user decide how to claim the data. xradar should just be capable to consume any of these files/streams. |
I just discovered now about obstore - a fsspec reimplemented in rust that seems to allow much faster data streaming. They are also merging the ObStore into Zarr (zarr-developers/zarr-python#1661). Might be worth to support also this type of file objects. (Maybe @aladinor might want to also check the speed improvement for IRIS/Segmet files 😄) |
Tracked also in #258 and #264
Xradar should support compress files as well as data streaming
pyart
library allows to open in different formats includingBz
,gz
and files stored in an s3 bucket (data) streaming. I think we might want to implement a similar solution to xradar reader.PyArt
The text was updated successfully, but these errors were encountered: