Skip to content

Commit e52fff9

Browse files
committed
Make return value depend on database response
1 parent a517c11 commit e52fff9

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

src/routers/openml/flows.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def flow_exists(
2525
status_code=http.client.NOT_FOUND,
2626
detail="Flow not found.",
2727
)
28-
return {"flow_id": 1}
28+
return {"flow_id": flow.id}
2929

3030

3131
@router.get("/{flow_id}")

tests/routers/openml/flows_test.py

+18
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,27 @@
11
import http.client
22

33
import deepdiff.diff
4+
from pytest_mock import MockerFixture
45
from starlette.testclient import TestClient
56

67

8+
def test_flow_exists_api(py_api: TestClient, mocker: MockerFixture) -> None:
9+
# Mock database.flows.get_by_namne(...) returns the flow with id one.
10+
fake_flow = mocker.MagicMock(id=2)
11+
mocked_db = mocker.patch(
12+
"database.flows.get_by_name",
13+
return_value=fake_flow,
14+
)
15+
response = py_api.get("/flows/exists/weka.ZeroR/Weka_3.9.0_12024")
16+
# assert mocked_db.assert_called_once_with(
17+
# name="weka.ZeroR",
18+
# external_version="Weka_3.9.0_12024",
19+
# )
20+
mocked_db.assert_called()
21+
assert response.status_code == http.client.OK
22+
assert response.json() == {"flow_id": fake_flow.id}
23+
24+
725
def test_flow_exists(py_api: TestClient) -> None:
826
response = py_api.get("/flows/exists/weka.ZeroR/Weka_3.9.0_12024")
927
assert response.status_code == http.client.OK

0 commit comments

Comments
 (0)