Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing the health of a rollout #181

Open
dudicoco opened this issue Oct 26, 2023 · 2 comments
Open

Testing the health of a rollout #181

dudicoco opened this issue Oct 26, 2023 · 2 comments

Comments

@dudicoco
Copy link

Hi,

Tools such as flagger and argo rollouts allow you to validate each step of a rollout/canary by performing smoke tests or checking metrics such as number of errors and latency.

Are there any plans on supporting this within kruise rollouts?
What is the point of a progressive rollouts without an automatic way of validating the progress?

@wparr-circle
Copy link

wparr-circle commented Aug 21, 2024

Was looking for the same.
It would be good if on the website https://openkruise.io/rollouts/introduction#kruise-rollouts-vs-other-components clearly documented that Metric Analysis is not currently supported (I created openkruise/openkruise.io#200 to clarify).

It looks like there is a skeleton built for metric analysis during a canary upgrade, however this is currently implemented as:
https://github.com/openkruise/rollouts/blob/master/pkg/controller/rollout/rollout_canary.go#L288

func (m *canaryReleaseManager) doCanaryMetricsAnalysis(c *RolloutContext) (bool, error) {
	// todo
	return true, nil
}

@wparr-circle
Copy link

Duplicates #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants