Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PolytopeWalk: Sparse MCMC Sampling over Polytopes #7872

Open
editorialbot opened this issue Mar 4, 2025 · 23 comments
Open

[PRE REVIEW]: PolytopeWalk: Sparse MCMC Sampling over Polytopes #7872

editorialbot opened this issue Mar 4, 2025 · 23 comments
Assignees
Labels
C++ pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 4, 2025

Submitting author: @bsun1220 (Benny Sun)
Repository: https://github.com/ethz-randomwalk/polytopewalk
Branch with paper.md (empty if default branch):
Version: v1.0.17
Editor: @vissarion
Reviewers: Pending
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c7799a15f0b75c91e43ff4d8da5c5d85"><img src="https://joss.theoj.org/papers/c7799a15f0b75c91e43ff4d8da5c5d85/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c7799a15f0b75c91e43ff4d8da5c5d85/status.svg)](https://joss.theoj.org/papers/c7799a15f0b75c91e43ff4d8da5c5d85)

Author instructions

Thanks for submitting your paper to JOSS @bsun1220. Currently, there isn't a JOSS editor assigned to your paper.

@bsun1220 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Mar 4, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.03 s (2772.8 files/s, 191922.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             27            352            101           2113
C/C++ Header                    25            230            626            460
Python                           6             99             34            326
YAML                             5             49             18            280
TeX                              1             23              0            191
Markdown                         2             66              0            177
CMake                            6             36             16            124
Jupyter Notebook                 2              0            361            111
reStructuredText                12             96            213             71
TOML                             1              7              7             43
DOS Batch                        1              8              1             26
Text                             2              0              0              9
Bourne Shell                     2             12             75              7
-------------------------------------------------------------------------------
SUM:                            92            978           1452           3938
-------------------------------------------------------------------------------

Commit count by author:

   130	Benny Sun
   102	Yuansi Chen
    35	bsun1220
     1	Ikko Eltociear Ashimine
     1	whatwilliam

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Wordcount for paper.md is 1573

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1093/nar/gkv1049 is OK
- 10.32614/rj-2021-077 is OK
- 10.21105/joss.00061 is OK
- 10.1175/2007JCLI1571.1 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Approximating discrete probability distributions w...
- No DOI given, and none found for title: Sampling with Riemannian Hamiltonian Monte Carlo i...
- No DOI given, and none found for title: Fast MCMC Sampling Algorithms on Polytopes
- No DOI given, and none found for title: A Simple Analysis of the Dikin Walk
- No DOI given, and none found for title: Geometric Random Walks: A Survey
- No DOI given, and none found for title: Practical volume computation of structured convex ...
- No DOI given, and none found for title: Creation and analysis of biochemical constraint-ba...

❌ MISSING DOIs

- 10.1016/0004-3702(91)90084-w may be a valid DOI for title: Probabilistic Reasoning in Intelligent Systems:  N...
- 10.1145/3357713.3384272 may be a valid DOI for title: Strong Self-Concordance and Sampling
- 10.1561/9781680833911 may be a valid DOI for title: The many faces of degeneracy in conic optimization
- 10.1007/s101070050099 may be a valid DOI for title: Hit-and-run mixes fast
- 10.1007/s10107-003-0447-x may be a valid DOI for title: How to compute the volume in high dimension?
- 10.1016/j.ejor.2023.03.021 may be a valid DOI for title: Revisiting degeneracy, strict feasibility, stabili...
- 10.1016/j.softx.2021.100659 may be a valid DOI for title: Polyrun: A Java library for sampling from the boun...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

pocoMC: A Python package for accelerated Bayesian inference in astronomy and cosmology
Submitting author: @minaskar
Handling editor: @dfm (Active)
Reviewers: @kazewong, @marylou-gabrie
Similarity score: 0.6470

Efficient Polyhedral Gravity Modeling in Modern C++ and Python
Submitting author: @schuhmaj
Handling editor: @dfm (Active)
Reviewers: @mikegrudic, @santisoler
Similarity score: 0.6462

MParT: Monotone Parameterization Toolkit
Submitting author: @mparno
Handling editor: @diehlpk (Active)
Reviewers: @ansgarwenzel, @f-t-s
Similarity score: 0.6446

pyOptSparse: A Python framework for large-scale constrained nonlinear optimization of sparse systems
Submitting author: @nwu63
Handling editor: @poulson (Retired)
Reviewers: @jgoldfar, @vissarion, @matbesancon
Similarity score: 0.6422

sparse-lm: Sparse linear regression models in Python
Submitting author: @lbluque
Handling editor: @jbytecode (Active)
Reviewers: @htjb, @mhu48
Similarity score: 0.6385

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@crvernon
Copy link

crvernon commented Mar 4, 2025

@editorialbot invite @vissarion as editor

👋 @vissarion will you be able to take this one on as editor?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@crvernon
Copy link

crvernon commented Mar 4, 2025

👋 @bsun1220 - while I am getting a topic editor assigned to your submission, please reduce the word count of your paper to <= 1000 words. Thanks.

@bsun1220
Copy link

bsun1220 commented Mar 4, 2025

@crvernon Sounds good, I have cut down on the paper!

@vissarion
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @vissarion is now the editor

@bsun1220
Copy link

bsun1220 commented Mar 5, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Efficient Polyhedral Gravity Modeling in Modern C++ and Python
Submitting author: @schuhmaj
Handling editor: @dfm (Active)
Reviewers: @mikegrudic, @santisoler
Similarity score: 0.6473

PxMCMC: A Python package for proximal Markov Chain Monte Carlo
Submitting author: @auggiemarignier
Handling editor: @mstimberg (Active)
Reviewers: @jeremiecoullon, @mattpitkin
Similarity score: 0.6466

MParT: Monotone Parameterization Toolkit
Submitting author: @mparno
Handling editor: @diehlpk (Active)
Reviewers: @ansgarwenzel, @f-t-s
Similarity score: 0.6343

pyOptSparse: A Python framework for large-scale constrained nonlinear optimization of sparse systems
Submitting author: @nwu63
Handling editor: @poulson (Retired)
Reviewers: @jgoldfar, @vissarion, @matbesancon
Similarity score: 0.6342

PyVBMC: Efficient Bayesian inference in Python
Submitting author: @Bobby-Huggins
Handling editor: @rkurchin (Active)
Reviewers: @matt-graham, @isdanni
Similarity score: 0.6316

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@bsun1220
Copy link

bsun1220 commented Mar 5, 2025

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @bsun1220, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@bsun1220
Copy link

bsun1220 commented Mar 5, 2025

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.03 s (2800.7 files/s, 193795.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             27            352            101           2113
C/C++ Header                    25            230            626            460
Python                           6             99             34            326
YAML                             5             49             18            280
TeX                              1             23              0            191
Markdown                         2             65              0            176
CMake                            6             36             16            124
Jupyter Notebook                 2              0            361            111
reStructuredText                12             96            213             71
TOML                             1              7              7             43
DOS Batch                        1              8              1             26
Text                             2              0              0              9
Bourne Shell                     2             12             75              7
-------------------------------------------------------------------------------
SUM:                            92            977           1452           3937
-------------------------------------------------------------------------------

Commit count by author:

   130	Benny Sun
   102	Yuansi Chen
    37	bsun1220
     1	Ikko Eltociear Ashimine
     1	whatwilliam

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Wordcount for paper.md is 1255

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@bsun1220
Copy link

bsun1220 commented Mar 6, 2025

@bsun1220 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Using the reviewer suggestions from matt-graham who has a different paper on MCMC algorithms, @vissarion if you need help finding reviewers, I saw that larryshamalama, vankesteren, robmoss, njtierney and martinmodrak all had relevant profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

4 participants