[PRE REVIEW]: SpectralUnmixing: A general Julia package for unmixing spectroscopy data

[editorialbot]

Submitting author: @pgbrodrick (Philip G Brodrick)
Repository: https://github.com/emit-sds/SpectralUnmixing/
Branch with paper.md (empty if default branch): joss
Version: v0.2.4
Editor: Pending
Reviewers: Pending
Managing EiC: Kevin M. Moerman

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1bd8d9d815fe63255c51174284dd48ed"><img src="https://joss.theoj.org/papers/1bd8d9d815fe63255c51174284dd48ed/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1bd8d9d815fe63255c51174284dd48ed/status.svg)](https://joss.theoj.org/papers/1bd8d9d815fe63255c51174284dd48ed)

Author instructions

Thanks for submitting your paper to JOSS @pgbrodrick. Currently, there isn't a JOSS editor assigned to your paper.

@pgbrodrick if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.98  T=0.05 s (404.5 files/s, 150422.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TOML                             2            380              1           1762
Julia                            7            361            625           1174
CSV                              2              0              0            258
Markdown                         3             40              0            134
TeX                              1              9              0            102
Jupyter Notebook                 1              0           2989             94
YAML                             3             10             13             73
Bourne Shell                     2             17             32             51
Python                           1             11              4             41
-------------------------------------------------------------------------------
SUM:                            22            828           3664           3689
-------------------------------------------------------------------------------

Commit count by author:

    25	Phil Brodrick
    21	pgbrodrick
    19	Winston Olson-Duvall
     8	Vatsal A Jhalani
     2	fotxoa
     1	brodrick

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 864

✅ The paper includes a Statement of need section

[editorialbot]

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.rse.2009.03.018 is OK
- 10.1016/S0034-4257(98)00037-6 is OK
- 10.1016/S0034-4257(00)00126-7 is OK
- 10.22541/essoar.173193387.79878484/v1 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: The Earth surface mineral dust source investigatio...
- No DOI given, and none found for title: Statistical learning with sparsity

❌ MISSING DOIs

- 10.1016/j.icarus.2010.01.030 may be a valid DOI for title: Minerals mapping of the lunar surface with Clement...
- 10.1016/j.pss.2007.12.007 may be a valid DOI for title: Analysis of OMEGA/Mars express data hyperspectral ...
- 10.1080/01431160802549328 may be a valid DOI for title: Modelling land-cover types using multiple endmembe...
- 10.1016/s0034-4257(01)00207-3 may be a valid DOI for title: Practical limits on hyperspectral vegetation discr...

❌ INVALID DOIs

- None

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[Kevin-Mattheus-Moerman]

@pgbrodrick Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps.
I have briefly reviewed this submission. Unfortunately I think it is not ready for consideration by JOSS yet. Please can you work on the below before we can proceed.

• Please study the above reference check ☝️ and see if you can address any of the reported potential DOI issues. You can add/amend DOI entries in your .bib file, and call @editorialbot check references here to check them again.
• Your project appears to lack contributing guidelines at the moment. Please work to add these and to mention/link to them in your README. You could for instance create a CONTRIBUTING.md file (see here for some examples: https://contributing.md/example/).
• Extend the README as is custom for Julia packages e.g. add a longer and clearer project description, refer to documentation, testing, the license etc. and consider including clear badges for these.
• Add detailed documentation and refer to it in the README.
• Add automated testing/CI and refer to it in the README.
• Register the package as a Julia package, this is desirable as several "checks and balances" are worked out to get to that point, which are also required for JOSS.

Lastly, we currently have a backlog of submissions to process and several editors in this domain are already at capacity. Hence I will waitlist this submission for now. We aim to assign an editor as soon as one becomes available (and when the above has been addressed).