Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: DynamicAll #7794

Open
editorialbot opened this issue Feb 19, 2025 · 6 comments
Open

[REVIEW]: DynamicAll #7794

editorialbot opened this issue Feb 19, 2025 · 6 comments
Assignees
Labels
review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @jguerra-astro (Juan Guerra)
Repository: https://github.com/jguerra-astro/dynamicall
Branch with paper.md (empty if default branch): main
Version: e.g V1.0
Editor: @JBorrow
Reviewers: @sophialilleengen, @michael-petersen
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a26f20391c1360ed1f2806fa09065816"><img src="https://joss.theoj.org/papers/a26f20391c1360ed1f2806fa09065816/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a26f20391c1360ed1f2806fa09065816/status.svg)](https://joss.theoj.org/papers/a26f20391c1360ed1f2806fa09065816)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@sophialilleengen & @michael-petersen, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @JBorrow know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@sophialilleengen, please create your checklist typing: @editorialbot generate my checklist

@michael-petersen, please create your checklist typing: @editorialbot generate my checklist

@editorialbot editorialbot added review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Feb 19, 2025
@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1086/670067 is OK
- 10.1093/mnras/sty2672 is OK
- 10.1093/mnras/sty2672 is OK
- 10.1111/j.1365-2966.2010.16753.x is OK
- 10.1093/mnras/278.2.488 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.21105/joss.00024 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.3847/1538-3881/aabc4f is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.21105/joss.01143 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Galactic Dynamics: Second Edition
- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: Composable Effects for Flexible and Accelerated Pr...
- No DOI given, and none found for title: Pyro: Deep Universal Probabilistic Programming
- No DOI given, and none found for title: pytest x.y

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.07 s (591.9 files/s, 310571.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          12           1018           2100           2928
Jupyter Notebook                15              0          10428           2485
XML                              1              2              0            826
YAML                             4              4              5            642
TeX                              1             16              0            239
Markdown                         1             16              0             57
reStructuredText                 3             63             54             48
DOS Batch                        1              8              1             26
make                             1              4              7              9
TOML                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                            40           1131          12595           7263
-------------------------------------------------------------------------------

Commit count by author:

   111	Juan Guerra
    22	jguerra-astro

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 607

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

2 participants