Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: LabRPS: Laboratory for Random Phenomena Simulation #7792

Open
editorialbot opened this issue Feb 18, 2025 · 13 comments
Open

[PRE REVIEW]: LabRPS: Laboratory for Random Phenomena Simulation #7792

editorialbot opened this issue Feb 18, 2025 · 13 comments
Labels
C++ C pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @kfdani (KOFFI TOGBENOU)
Repository: https://github.com/LabRPS/LabRPS
Branch with paper.md (empty if default branch):
Version: 0.1.0
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/215fb31dc0d3b17284e3a97b0d513c08"><img src="https://joss.theoj.org/papers/215fb31dc0d3b17284e3a97b0d513c08/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/215fb31dc0d3b17284e3a97b0d513c08/status.svg)](https://joss.theoj.org/papers/215fb31dc0d3b17284e3a97b0d513c08)

Author instructions

Thanks for submitting your paper to JOSS @kfdani. Currently, there isn't a JOSS editor assigned to your paper.

@kfdani if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Feb 18, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1115/1.3098999 is OK
- 10.1061/(ASCE)0733-9399(1988)114:11(1995) is OK
- 10.2514/6.1987-932 is OK
- 10.1061/(ASCE)0733-9399(1991)117:5(1037) is OK
- 10.1061/(ASCE)EM.1943-7889.0001400 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- https://doi.org/10.1016/j.jweia.2008.02.048 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/S0266-8920(08)80001-X is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.engstruct.2003.12.009 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/0022-460X(72)90600-1 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/0266-8920(93)90002-D is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.jweia.2016.01.005 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.jweia.2017.07.005 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=5.83 s (897.5 files/s, 341203.8 lines/s)
---------------------------------------------------------------------------------------
Language                             files          blank        comment           code
---------------------------------------------------------------------------------------
Qt Linguist                            330           1805              0         817914
C++                                   1700          82779          81989         404821
C/C++ Header                          1335          39434          62448         155489
SVG                                    534            323            370         136789
Qt                                     192             79              0          40959
XML                                    226            338             68          26217
Python                                 192           5114          10080          25420
C                                       27           3842           2934          24664
Markdown                               255           7648              5          19535
CMake                                  190           2367           1299          12321
HTML                                   117            128            146          12062
Text                                    42            510              0           2250
CSS                                      7            144             58           1055
YAML                                    12             50            114            928
Bourne Shell                            16             86             96            824
XSD                                      3              0              7            749
diff                                     2             30            172            515
lex                                      3            128             88            479
JavaScript                               2             76             29            415
yacc                                     3             57             77            266
SQL                                      1              3              3            228
DOS Batch                                6             40             43            219
Windows Module Definition                2              3              0            162
Dockerfile                               6             30              6            149
TeX                                      1             11              0            137
Bourne Again Shell                       2              7              5             73
reStructuredText                         8             92             76             63
Starlark                                 2              0              0             54
Objective-C++                            1              0              0             40
JSON                                     4              9              0             37
Qt Project                               3              2              1             30
Prolog                                   4              7              0             27
Windows Resource File                    2              2             11             23
Meson                                    1              4              0             20
PO File                                  1              2              6             18
Swift                                    1              2              2             18
CUDA                                     1              3              8              8
ProGuard                                 1              2              3              2
---------------------------------------------------------------------------------------
SUM:                                  5235         145157         160144        1684980
---------------------------------------------------------------------------------------

Commit count by author:

   267	kfdani
    11	koffi togbenou
     4	unknown
     1	Eklou116
     1	chuanjinyu

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Wordcount for paper.md is 1495

🔴 Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Problem with affiliations for Koffi Togbenou, perhaps the affiliations index need quoting?.

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v2.0 (Check here for OSI approval)

@danielskatz
Copy link

👋 @kfdani - note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@danielskatz
Copy link

Also, the repo you are submitting has ~500,000 lines of C/C++/header code. I assume much of this is not actually your contribution as the submission that you want reviewed? Can you explain what part of the repo is your contribution?

@kfdani
Copy link

kfdani commented Feb 18, 2025

Also, the repo you are submitting has ~500,000 lines of C/C++/header code. I assume much of this is not actually your contribution as the submission that you want reviewed? Can you explain what part of the repo is your contribution?

Thank you for taking the time to review my article. The following directories contain our main contributions:

src/Mod/GeneralTools
src/Mod/WindLabTools
src/Mod/SeismicLabTools
src/Mod/SeaLabTools
src/Mod/UseLabTools
src/Mod/WindLabAPI
src/Mod/SeismicLabAPI
src/Mod/SeaLabAPI
src/Mod/UseLabAPI
src/Mod/WindLab
src/Mod/SeismicLab
src/Mod/SeaLab
src/Mod/UseLab
src/Mod/WindLabPlugins
src/Mod/SeismicLabPlugins
src/Mod/SeaLabPlugins
src/Mod/UseLabPlugins

@kfdani
Copy link

kfdani commented Feb 18, 2025

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1115/1.3098999 is OK
- 10.1016/j.jweia.2008.02.048 is OK
- 10.1016/S0266-8920(08)80001-X is OK
- 10.1061/(ASCE)0733-9399(1988)114:11(1995) is OK
- 10.2514/6.1987-932 is OK
- 10.1016/j.engstruct.2003.12.009 is OK
- 10.1061/(ASCE)0733-9399(1991)117:5(1037) is OK
- 10.1016/0022-460X(72)90600-1 is OK
- 10.1016/0266-8920(93)90002-D is OK
- 10.1016/j.jweia.2016.01.005 is OK
- 10.1061/(ASCE)EM.1943-7889.0001400 is OK
- 10.1016/j.jweia.2017.07.005 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@kfdani
Copy link

kfdani commented Feb 18, 2025

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ C pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

3 participants