Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Million Points of Light (MPoL): a PyTorch library for radio interferometric imaging and inference #7722

Open
editorialbot opened this issue Jan 26, 2025 · 15 comments
Labels
pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @iancze (Ian Czekala)
Repository: https://github.com/MPoL-dev/MPoL
Branch with paper.md (empty if default branch):
Version: v0.3.0-alpha
Editor: Pending
Reviewers: Pending
Managing EiC: Warrick Ball

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0f6fc9673091ab978cff13b8a1466c7e"><img src="https://joss.theoj.org/papers/0f6fc9673091ab978cff13b8a1466c7e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0f6fc9673091ab978cff13b8a1466c7e/status.svg)](https://joss.theoj.org/papers/0f6fc9673091ab978cff13b8a1466c7e)

Author instructions

Thanks for submitting your paper to JOSS @iancze. Currently, there isn't a JOSS editor assigned to your paper.

@iancze if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Jan 26, 2025
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.3847/2041-8213/aaf741 is OK
- 10.1088/1538-3873/ac9642 is OK
- 10.1088/1538-3873/acdf84 is OK
- 10.21105/astro.2302.05163 is OK
- 10.3847/1538-3881/ab40a7 is OK
- 10.3847/2041-8213/ad41df is OK
- 10.48550/arXiv.2305.09121 is OK
- 10.48550/arXiv.2311.18012 is OK
- 10.1093/mnras/staa1365 is OK
- 10.3847/2041-8213/ab0ec7 is OK
- 10.3847/2041-8213/ab0e85 is OK
- 10.3847/2041-8213/ac0f83 is OK
- 10.3847/2041-8213/aac6dc is OK
- 10.1146/annurev-astro-031220-010302 is OK
- 10.1109/JPROC.2009.2021005 is OK
- 10.1146/annurev.aa.24.090186.001015 is OK
- 10.3847/1538-4357/ad84df is OK
- 10.1007/978-3-319-44431-4 is OK
- 10.48550/arXiv.2009.04345 is OK
- 10.48550/arXiv.1912.01703 is OK
- 10.1109/JPROC.2009.2020572 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.48550/arXiv.1711.05101 is OK
- 10.1093/mnras/sty409 is OK
- 10.3847/2041-8213/aaedae is OK
- 10.48550/arXiv.2311.18012 is OK
- 10.3847/2041-8213/aaf7a0 is OK
- 10.1086/670067 is OK
- 10.1051/0004-6361/201016082 is OK
- 10.1088/1538-3873/ace216 is OK
- 10.1093/mnras/stac1285 is OK
- 10.1051/0004-6361/201323094 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Aperture Synthesis with a Non-Regular Distribution...
- No DOI given, and none found for title: An efficient implementation of the algorithm ’CLEA...
- No DOI given, and none found for title: CASA Architecture and Applications
- No DOI given, and none found for title: TorchKbNufft: A High-Level, Hardware-Agnostic Non-...
- No DOI given, and none found for title: Essential Radio Astronomy
- No DOI given, and none found for title: Automatic Differentiation in Machine Learning: a S...
- No DOI given, and none found for title: Pyro: deep universal probabilistic programming
- No DOI given, and none found for title: The No-U-Turn sampler: adaptively setting path len...

❌ MISSING DOIs

- 10.1201/b10905-6 may be a valid DOI for title: MCMC using Hamiltonian dynamics
- 10.1051/aas:1996146 may be a valid DOI for title: Understanding radio polarimetry. I. Mathematical f...

❌ INVALID DOIs

- https://doi.org/10.1007/978-3-031-45468-4 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.ascom.2017.11.003 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.07 s (1062.9 files/s, 176221.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          39           2192           3968           4254
Markdown                        27            349              0            873
TeX                              1             53              0            668
YAML                             6             10              6            196
TOML                             1             10              2            110
DOS Batch                        1              8              1             26
make                             1              7              6             23
CSS                              1              0              0              4
-------------------------------------------------------------------------------
SUM:                            77           2629           3983           6154
-------------------------------------------------------------------------------

Commit count by author:

   645	Ian Czekala
   553	Jeff Jennings
    44	Kadri Nizam
    35	Hannah Grzybowski
    25	trq5014
    23	RCF42
    19	Tyler Quinn
     8	briannazawadzki
     3	tquinn39
     2	Brianna Zawadzki

@editorialbot
Copy link
Collaborator Author

Paper file info:

⚠️ Wordcount for paper.md is 1559

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

deeplenstronomy: A dataset simulation package for strong gravitational lensing
Submitting author: @rmorgan10
Handling editor: @pdebuyl (Active)
Reviewers: @shreyasbapat, @jiwoncpark
Similarity score: 0.7321

Anime: Atmospheric and Instrument Models in the Measurement Equation
Submitting author: @iniyannatarajan
Handling editor: @dfm (Active)
Reviewers: @kiranshila, @michael-petersen
Similarity score: 0.7261

SIMIO-continuum: Connecting simulations to ALMA observations
Submitting author: @nicokurtovic
Handling editor: @ivastar (Active)
Reviewers: @adeleplunkett, @jeffjennings
Similarity score: 0.7259

SkyPy: A package for modelling the Universe
Submitting author: @rrjbca
Handling editor: @arfon (Active)
Reviewers: @cescalara, @rmorgan10
Similarity score: 0.7153

21cmSense v2: A modular, open-source 21 cm sensitivity calculator
Submitting author: @steven-murray
Handling editor: @arfon (Active)
Reviewers: @mattpitkin, @htjb
Similarity score: 0.7107

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@warrickball
Copy link

Hi @iancze, thanks for your submission to JOSS. While co-publication in other journals doesn't necessarily rule out a publication in JOSS, the 2023 PASP article does make repeated and specific reference to MPoL, so I'm going to ask the editorial board to consider whether the implementation of the software itself reflects a sufficient substantial scientific effort for JOSS's purposes. This review should take a week or two. Sorry for the additional wait!

@warrickball
Copy link

warrickball commented Jan 26, 2025

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@warrickball
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Jan 26, 2025
@iancze
Copy link

iancze commented Jan 31, 2025

@editorialbot generate preprint

@editorialbot
Copy link
Collaborator Author

📄 Preprint file created: Find it here in the Artifacts list 📄

@warrickball
Copy link

@iancze — There was enough support on the editorial board that I'm happy to continue with this submission. I'll note also that it looks like about 1600 lines of code have been added to the package since the PASP paper was published.

That said, all the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your continuing patience!

@warrickball warrickball added waitlisted Submissions in the JOSS backlog due to reduced service mode. and removed query-scope Submissions of uncertain scope for JOSS labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

3 participants