Skip to content

8300207: Add a pre-check for the number of canonical equivalent permutations in j.u.r.Pattern #3765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 17, 2025

I backport this for parity with 17.0.17-oracle.

Removed some comments as required by CSR


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8300207 needs maintainer approval
  • Change requires CSR request JDK-8357197 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8300207: Add a pre-check for the number of canonical equivalent permutations in j.u.r.Pattern (Bug - P4 - Requested)
  • JDK-8357197: Add a pre-check for the number of canonical equivalent permutations in j.u.r.Pattern (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3765/head:pull/3765
$ git checkout pull/3765

Update a local copy of the PR:
$ git checkout pull/3765
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3765/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3765

View PR using the GUI difftool:
$ git pr show -t 3765

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3765.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 17, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 030b071db1fb6197a2633a04b20aa95432a903bc 8300207: Add a pre-check for the number of canonical equivalent permutations in j.u.r.Pattern Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 17, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 17, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented Jul 18, 2025

Thanks for the review.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants