The hardcoded 5%/105% delivery tolerance window could match unrelated Transfer events sent to the solver address with a similar amount. For a 1,000,000 transfer this accepts anything between 950,000 and 1,050,000.
Maybe you should make the tolerance configurable via RebalanceConfig or extract as a named constant with documentation explaining the trade-off.
Originally posted by @shahnami in #316 (comment)
The hardcoded 5%/105% delivery tolerance window could match unrelated
Transferevents sent to the solver address with a similar amount. For a 1,000,000 transfer this accepts anything between 950,000 and 1,050,000.Maybe you should make the tolerance configurable via
RebalanceConfigor extract as a named constant with documentation explaining the trade-off.Originally posted by @shahnami in #316 (comment)