From fbab86e92242ae65ba1241277dadb0f689cc6fe5 Mon Sep 17 00:00:00 2001 From: Alexandru Coman Date: Tue, 27 Oct 2015 01:29:39 +0200 Subject: [PATCH] Fix private information disclosure Travis-CI will log every command and in order to avoid information disclosure the command should not contain plain text data. --- Rakefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Rakefile b/Rakefile index e696654..ed6d341 100644 --- a/Rakefile +++ b/Rakefile @@ -74,7 +74,7 @@ end def check_destination unless Dir.exist? CONFIG["destination"] - sh "git clone https://#{ENV['GIT_NAME']}:#{ENV['GH_TOKEN']}@github.com/#{CONFIG["github_user"]}/#{CONFIG["destination_repo"]}.git #{CONFIG["destination"]}" + sh "git clone https://$GIT_NAME:$GH_TOKEN@github.com/#{CONFIG["github_user"]}/#{CONFIG["destination_repo"]}.git #{CONFIG["destination"]}" end end @@ -185,8 +185,8 @@ namespace :site do # Configure git if this is run in Travis CI if ENV["TRAVIS"] - sh "git config --global user.name '#{ENV['GIT_NAME']}'" - sh "git config --global user.email '#{ENV['GIT_EMAIL']}'" + sh "git config --global user.name '$GIT_NAME'" + sh "git config --global user.email '$GIT_EMAIL'" sh "git config --global push.default simple" end