-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect the nonce endpoint #461
Comments
There was some discussion on this in the prior issue/PR: #404 |
Also some discussion in #381 - in particular this part #381 (comment) about GET vs POST and #381 (comment) on protection of the endpoint. |
My 2 cents. I checked the comments in #381 and the current OID4VCI draft. If the only way to use a nonce endpoint—where a fresh c_nonce value can be obtained—is for proof of possession of key material in a subsequent request to the Credential Endpoint, and this call is always made after the Token request, then why don’t we secure the nonce endpoint? Are there other use cases where we need a nonce before acquiring the Token? |
@oriolcanades I do not see the need to ask for a nonce if you don't have a previously obtained access token. |
I also agree that the nonce endpoint must be protected. What was this WG (#381 (comment)) discussion about? |
Having this endpoint unprotected is not a good idea:
This endpoint should be protected with the access token that the wallet just obtained, just like the credential endpoint. Thus, the nonce would be also linked to a specific wallet which would make it simple for the Issuer to match the nonce when receiving it in the subsequent credential request.
Also, it would make more sense for this endpoint to implement a GET method instead of a POST.
The text was updated successfully, but these errors were encountered: