-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[habmin] Replace vis.js (almende/vis) dependency due to EOL #69
Comments
I don't think it is practically possible to replace visjs without a lot of work - if the build fails, then we'll have to deal with this or remove all charting etc. |
You can also use one of the forks (see linked issue) instead of removing everything. ;-) |
@cdjackson Why did you close the issue? |
There are lots of dependencies that are not maintained - do we really want to open issues for them all.
I simply suggest that if there is an issue in future, then we deal with it. I don’t really see why anything should stop compiling, or stop working - the dependencies that already exist should not be removed, and if they are, then let’s worry about it then.
… On 27 May 2019, at 09:54, Kai Kreuzer ***@***.***> wrote:
@cdjackson <https://github.com/cdjackson> Why did you close the issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#69?email_source=notifications&email_token=AAH6IQZXFLALPBCHH3UULSLPXOOVTA5CNFSM4HPZ23Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJG63I#issuecomment-496136045>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAH6IQYIQUR5WVR6BN5IDILPXOOVTANCNFSM4HPZ23YQ>.
|
I thought to understand from #68 (comment) that there actually IS already an issue and that our codebase does not build anymore. |
Oh, I hadn’t seen that - feel free to reopen this but I have no time at the moment to look at it.
… On 27 May 2019, at 11:39, Kai Kreuzer ***@***.***> wrote:
I thought to understand from #68 (comment) <#68 (comment)> that there actually IS already an issue and that our codebase does not build anymore.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#69?email_source=notifications&email_token=AAH6IQ5R2ESAQ2UCNGGQX2DPXO257A5CNFSM4HPZ23Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJO2NY#issuecomment-496168247>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAH6IQZKGB7ODO5N6BILZDLPXO257ANCNFSM4HPZ23YQ>.
|
The issue is fixed for now since the repository got reenabled so habmin builds again. But since the project is EOL it might be a good idea to investigate if it can be replaced with one of the forks. |
Thanks for the clarification, @wborn. Instead of relying on a foreign fork, shall we simply create a fork of it under the openhab org and point out build to that? |
It might be a good idea to fork it so if it goes down again we have a backup and can create an alternative. |
Thanks...
|
Created https://github.com/openhab/vis - anybody wants to adapt our build to use it? |
I'll close this issue since HABmin is no longer supported in OH3 (#154). |
As stated in almende/vis#4259 vis.js (almende/vis) is no longer maintained.
The build may fail one day when their GitHub project is removed for some reason (see #68 (comment)).
CC: @cdjackson
The text was updated successfully, but these errors were encountered: