Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[habmin] Replace vis.js (almende/vis) dependency due to EOL #69

Closed
wborn opened this issue May 27, 2019 · 12 comments
Closed

[habmin] Replace vis.js (almende/vis) dependency due to EOL #69

wborn opened this issue May 27, 2019 · 12 comments

Comments

@wborn
Copy link
Member

wborn commented May 27, 2019

As stated in almende/vis#4259 vis.js (almende/vis) is no longer maintained.

The build may fail one day when their GitHub project is removed for some reason (see #68 (comment)).

CC: @cdjackson

@cdjackson
Copy link
Contributor

I don't think it is practically possible to replace visjs without a lot of work - if the build fails, then we'll have to deal with this or remove all charting etc.

@wborn
Copy link
Member Author

wborn commented May 27, 2019

You can also use one of the forks (see linked issue) instead of removing everything. ;-)

@kaikreuzer
Copy link
Member

@cdjackson Why did you close the issue?

@cdjackson
Copy link
Contributor

cdjackson commented May 27, 2019 via email

@kaikreuzer
Copy link
Member

I thought to understand from #68 (comment) that there actually IS already an issue and that our codebase does not build anymore.

@cdjackson
Copy link
Contributor

cdjackson commented May 27, 2019 via email

@cdjackson cdjackson reopened this May 27, 2019
@wborn
Copy link
Member Author

wborn commented May 27, 2019

The issue is fixed for now since the repository got reenabled so habmin builds again. But since the project is EOL it might be a good idea to investigate if it can be replaced with one of the forks.

@kaikreuzer
Copy link
Member

Thanks for the clarification, @wborn. Instead of relying on a foreign fork, shall we simply create a fork of it under the openhab org and point out build to that?

@wborn
Copy link
Member Author

wborn commented May 27, 2019

It might be a good idea to fork it so if it goes down again we have a backup and can create an alternative.

@cdjackson
Copy link
Contributor

cdjackson commented May 27, 2019 via email

@kaikreuzer
Copy link
Member

Created https://github.com/openhab/vis - anybody wants to adapt our build to use it?

@wborn
Copy link
Member Author

wborn commented Feb 13, 2020

I'll close this issue since HABmin is no longer supported in OH3 (#154).

@wborn wborn closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants