From 53e702773df79eb9378ceef4ecffcf41763b2ab3 Mon Sep 17 00:00:00 2001 From: VariableVince <24507472+VariableVince@users.noreply.github.com> Date: Sun, 22 Feb 2026 22:45:44 +0100 Subject: [PATCH] Unnecessary Array.from on player.alliances() which already returns an array. Also saving in const isn't really necessary, same for the array in the loop below --- src/core/execution/PlayerExecution.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/core/execution/PlayerExecution.ts b/src/core/execution/PlayerExecution.ts index 35799a781a..55d2eb062a 100644 --- a/src/core/execution/PlayerExecution.ts +++ b/src/core/execution/PlayerExecution.ts @@ -81,15 +81,13 @@ export class PlayerExecution implements Execution { // Record stats this.mg.stats().goldWork(this.player, goldFromWorkers); - const alliances = Array.from(this.player.alliances()); - for (const alliance of alliances) { + for (const alliance of this.player.alliances()) { if (alliance.expiresAt() <= this.mg.ticks()) { alliance.expire(); } } - const embargoes = this.player.getEmbargoes(); - for (const embargo of embargoes) { + for (const embargo of this.player.getEmbargoes()) { if ( embargo.isTemporary && this.mg.ticks() - embargo.createdAt >