Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates] suggestion, split windows vs2019 and vs2022 as separate templates #8157

Open
dimitre opened this issue Oct 21, 2024 · 5 comments

Comments

@dimitre
Copy link
Member

dimitre commented Oct 21, 2024

I'm no regular Windows user, but I think it would be great if we had separate templates and core for vs2019 and vs2022
or another way of choosing between tools v142 / v143

@ofTheo
Copy link
Member

ofTheo commented Oct 21, 2024

At this point my feeling is we should only officially support one version of Visual Studio and include in our setup guide how to change the toolset ( which is usually just hitting okay on the dialog box that pops up ).

Maybe there is another reason for having multiple templates?
Just nervous about having to support additional things when so little is currently working.

@roymacdonald
Copy link
Member

I dont think it is a good idea. It just adds to the TO-DO list and I think that is unnecessary.
I agree with theo, just to support the newer version and update the setup guide.

@danoli3
Copy link
Member

danoli3 commented Oct 30, 2024

I designed the Apothecary stuff to allow for this, and new builds have VS2019 libraries deployed to bleeding as of today.

  • Just x64

Todo:

  • Restore VS2019 template with code changes (new cpp files added etc)
  • ProjectGenerator add template option
  • Add download_libs for 2019

@roymacdonald
Copy link
Member

Honestly, I don't see the point for doing this. What benefit you see from doing such? The issue I see is that you have one more template to care about, which also reflects on PG, etc.

@danoli3
Copy link
Member

danoli3 commented Nov 3, 2024

Yeah probably not needed as vs2022 is going to be prime for a while since no vs2024 is planned. Yet still a lot of devs live in 2019 land and since I already set this up I'll just fix up the PG and clone the latest project configs from 2024 for the 2019 it should still work the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants