Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds undercover gem to the stack #13101

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

filipefurtad0
Copy link
Contributor

@filipefurtad0 filipefurtad0 commented Jan 28, 2025

What? Why?

To make this effort work, we need to:

  • add the undecover gem and make sure all dependencies are correctly installed
  • add a task to the current build file to enable test coverage between a pull-requests' branch and the current master branch
  • I think ideally, we would have a separate job, which passes/fails like all other jobs (preferred, as it would indicate if the branch worsens/improves test coverage)

What should we test?

  • after pulling the branch and running bundle install, run bundle exec undercover --compare origin/master

    • it should output something like:
      " 🚨 WARNING: Coverage data is older than your latest changes and results might be incomplete. Re-run tests to update
      undercover: ✅ No coverage is missing in latest changes
      Undercover finished in 1.3279s"
  • look at the CI run for this branch; find a new job, dedicated to undecover. It should display a comparison with master branch and pass/fail, accordingly.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@filipefurtad0 filipefurtad0 marked this pull request as draft January 28, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress ⚙
Development

Successfully merging this pull request may close these issues.

[CI] Signal test coverage changes (SimpleCov + Undercover gems)
1 participant