Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "Refresh" button on the scan card, in case of Internet error #891

Closed
1 task
M123-dev opened this issue Jan 7, 2022 · 9 comments
Closed
1 task

Add a "Refresh" button on the scan card, in case of Internet error #891

M123-dev opened this issue Jan 7, 2022 · 9 comments
Assignees
@danagbemava
Labels
🎨 Mockup required Offline scan card

Comments

@M123-dev
Copy link
Member

M123-dev commented Jan 7, 2022 •
edited by teolemon
Loading

What

  • Add a "Refresh" button on the scan card, in case of Internet error

Part of

Screenshot

Screenshot_20220107-181109.jpg
@teolemon
Copy link
Member

teolemon commented Jan 8, 2022 •
edited
Loading

@teolemon teolemon changed the title Refresh button on Internet error Add a "Refresh" button on the scan card, in case of Internet error Jan 15, 2022
@teolemon teolemon mentioned this issue Jan 15, 2022
Open
@teolemon teolemon added scanning and removed scan labels Jan 15, 2022
@danagbemava
Copy link
Contributor

I would like to work on this

@M123-dev
Copy link
Member Author

Sounds good @danagbemava, if you need hints for the project structure or something like that just ask

@danagbemava
Copy link
Contributor

Thanks @M123-dev, will do

@danagbemava
Copy link
Contributor

Hi @M123-dev, I'm not familiar with Crowdin. After adding the new string in app_en.rb, how do I update the translations with Crowdin?

@teolemon
Copy link
Member

Crowdin will do that automatically from the original English file. You don't have to do anything.

@danagbemava danagbemava mentioned this issue Feb 11, 2022
Merged
@monsieurtanuki
Copy link
Contributor

@danagbemava @M123-dev It's fixed now, isn't it?

@danagbemava
Copy link
Contributor

@monsieurtanuki, yes, this is fixed

@monsieurtanuki
Copy link
Contributor

Fixed by #1105.

Repository owner moved this from Todo to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danagbemava danagbemava

Labels
🎨 Mockup required Offline scan card
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@teolemon @monsieurtanuki @M123-dev @danagbemava