-
-
Notifications
You must be signed in to change notification settings - Fork 386
feat: Convert Privacy warning to bottom sheet #6213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Convert Privacy warning to bottom sheet #6213
Conversation
We're using the following layout @Afroz-Shaikh #5755 |
You have the method |
Far better, could you add two buttons: |
Removed the top-right close icon to avoid confusion. Let me know if this works or if any design changes are needed—couldn't find related references in Figma. |
It's OK (in terms of UX). |
You can find more info on Sketch. For the red modal sheet + 2 buttons, you have an example in For the text in bold, you can create multiple translations (in Finally, for the two chips, the Widget with the arrow is called |
Thank you, @g123k. I’ll make the changes and update the PR accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This OK for me, please just bring back the old format from the translation file
packages/smooth_app/lib/pages/prices/product_price_add_page.dart
Outdated
Show resolved
Hide resolved
It's OK, but one final issue: your branch has conflicts |
Oh my bad, can you check now |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6213 +/- ##
==========================================
- Coverage 9.54% 6.10% -3.45%
==========================================
Files 325 462 +137
Lines 16411 27124 +10713
==========================================
+ Hits 1567 1656 +89
- Misses 14844 25468 +10624 ☔ View full report in Codecov by Sentry. |
Thanks a lot for your first contribution @Afroz-Shaikh |
Well done @Afroz-Shaikh 🍾 |
@Afroz-Shaikh I have received a report from a user who said the buttons are not visible on the screen. Attached is a screenshot and the app logs. |
What
Turned the Open Prices privacy warning into a bottom sheet for improved user experience and better alignment with the UI design standards.
Replaced the current modal/dialog with a Flutter showModalBottomSheet.
Screenshot
Fixes bug(s)
Fixes: #6183