Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image unselect in the expanded view accessible from the carousel #2427

Closed
3 tasks done
Tracked by #766
teolemon opened this issue Jun 29, 2022 · 10 comments · Fixed by #3618 or #3707
Closed
3 tasks done
Tracked by #766

Add image unselect in the expanded view accessible from the carousel #2427

teolemon opened this issue Jun 29, 2022 · 10 comments · Fixed by #3618 or #3707
Assignees
@BhuvanAde
Labels
image carousel https://github.com/openfoodfacts/smooth-app/issues/966 image upload images P2 🖼️ Photos - Photo manager

Comments

@teolemon
Copy link
Member

teolemon commented Jun 29, 2022 •
edited by monsieurtanuki
Loading

What

Part of
@teolemon teolemon mentioned this issue Jun 29, 2022
Closed
@M123-dev M123-dev mentioned this issue Aug 5, 2022
Closed
@teolemon teolemon added P3 P2 image carousel https://github.com/openfoodfacts/smooth-app/issues/966 and removed P3 labels Aug 19, 2022
@monsieurtanuki monsieurtanuki self-assigned this Jan 23, 2023
This was referenced Jan 23, 2023
Open
Merged
@monsieurtanuki
Copy link
Contributor

Minor change requested in #3618: add an "are you sure?" dialog when the user clicks on the "unselect image" button.

@monsieurtanuki
Copy link
Contributor

@BhuvanAde As suggested, please add the dialog.

@monsieurtanuki monsieurtanuki removed their assignment Jan 25, 2023
@BhuvanAde
Copy link
Contributor

@monsieurtanuki For the dialog shall the use the dialog from lib/generic_lib/dialogs/smooth_alert_dialog.dart

@monsieurtanuki
Copy link
Contributor

@BhuvanAde Please, as it's our app dialog.

@BhuvanAde
Copy link
Contributor

In app_localizations.dart is there any Are you sure? ? I just tried to find but couldn't find

@monsieurtanuki
Copy link
Contributor

@BhuvanAde If needed add one entry in app_en.arb and run flutter pub get.

@BhuvanAde
Copy link
Contributor

Screen.Recording.2023-01-30.at.10.40.23.PM.mov

@BhuvanAde
Copy link
Contributor

Shall I close this issue?

@BhuvanAde BhuvanAde mentioned this issue Jan 30, 2023
Closed
@monsieurtanuki
Copy link
Contributor

@BhuvanAde I haven't seen your related PR, which one is it?

@BhuvanAde
Copy link
Contributor

#3659 Is the PR. I'm working on toggle issue now. Can you please let me know if there are any other existing issues.
@monsieurtanuki

BhuvanAde added a commit to BhuvanAde/smooth-app that referenced this issue Feb 13, 2023
@BhuvanAde
feat: added dialog if users click on unselect image button openfoodfa…
902deba 
…cts#2427

Signed-off-by: BhuvanAde <[email protected]>
@BhuvanAde BhuvanAde mentioned this issue Feb 13, 2023
Merged
BhuvanAde added a commit to BhuvanAde/smooth-app that referenced this issue Feb 13, 2023
@BhuvanAde
feat: added dialog if users click on unselect image button openfoodfa…
62cc9c3 
…cts#2427

Signed-off-by: BhuvanAde <[email protected]>
monsieurtanuki added a commit that referenced this issue Feb 14, 2023
@BhuvanAde @monsieurtanuki
feat: added dialog if users click on unselect image button #2427 (#3707)
0dd30c4 
* feat: added dialog if users click on unselect image button #2427

Signed-off-by: BhuvanAde <[email protected]>

* Update packages/smooth_app/lib/l10n/app_en.arb

* Update packages/smooth_app/lib/l10n/app_en.arb

* feat: added dialog if users click on unselect image button #2427

Signed-off-by: BhuvanAde <[email protected]>

* Update packages/smooth_app/lib/l10n/app_en.arb

---------

Signed-off-by: BhuvanAde <[email protected]>
Co-authored-by: monsieurtanuki <[email protected]>
@github-actions github-actions bot mentioned this issue Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BhuvanAde BhuvanAde

Labels
image carousel https://github.com/openfoodfacts/smooth-app/issues/966 image upload images P2 🖼️ Photos - Photo manager
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
3 participants
@teolemon @monsieurtanuki @BhuvanAde