Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapping on "Unknown product match" should open a road to get the match #1118

Open
Tracked by #1284
teolemon opened this issue Feb 11, 2022 · 3 comments
Open
Tracked by #1284
Labels
✏️ Contribution 🎨 Mockup required 🎯 P0 personal scoring 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Milestone

Comments

@teolemon
Copy link
Member

teolemon commented Feb 11, 2022

Who for

  • Users who get "Unknown product match" on a product, despite no clear missing data

What

  • Tapping on "Unknown product match" should open
    • a screen with an explanation of what's missing to get a match and the required editing sections required to get the match "Good match" or "Bad match"

Part of

@teolemon teolemon added 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. and removed broken-template labels Feb 11, 2022
@teolemon teolemon moved this to Todo in Road to Scores Feb 11, 2022
@teolemon teolemon added Epic and removed ♞ epic labels Mar 16, 2022
@teolemon teolemon added the P3 label Mar 31, 2022
@teolemon teolemon added this to the V 1 milestone Mar 31, 2022
@teolemon teolemon removed the Epic label Apr 11, 2022
@teolemon teolemon moved this from Todo (ready 2 dev) to To discuss and validate in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 11, 2022
@teolemon teolemon modified the milestones: V1, V1.1 Jun 18, 2022
@teolemon teolemon added P2 and removed P3 labels Aug 7, 2022
@teolemon teolemon added 🎯 P0 and removed P2 labels Jun 15, 2023
@monsieurtanuki monsieurtanuki self-assigned this Aug 12, 2023
@monsieurtanuki
Copy link
Contributor

@teolemon That's what we are able to do with openfoodfacts/openfoodfacts-dart#786:

product page explanations
Screenshot_2023-08-12-19-11-28 Screenshot_2023-08-12-19-12-00

@monsieurtanuki
Copy link
Contributor

Same thing with more cases:
Screenshot_2023-08-12-22-02-23

@monsieurtanuki
Copy link
Contributor

@teolemon What we need here is, for each attribute, an action to "un-unknow" it.
For the moment we only implement that kind of actions in KP, like in KnowledgePanelAction, according to what is provided by the server as KP action:

  • addCategories
  • addIngredientsText
  • addIngredientsImage
  • addPackagingImage
  • addPackagingText
  • addNutritionFacts
  • addOrigins
  • addStores
  • addLabels
  • addCountries

Should we extend it to all attributes, so that if one attribute is unknown, we can nudge the user into adding data accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Contribution 🎨 Mockup required 🎯 P0 personal scoring 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Projects
Status: Todo
Status: To Discuss and Validate
Status: 💬 To discuss and validate
Development

No branches or pull requests

2 participants