Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get new insights after toggling selection #28

Open
hangy opened this issue Jun 26, 2019 · 2 comments
Open

Get new insights after toggling selection #28

hangy opened this issue Jun 26, 2019 · 2 comments

Comments

@hangy
Copy link
Member

hangy commented Jun 26, 2019

Describe the bug
Insight filter is only applied after the loaded questions are exhausted.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://de.openfoodfacts.org/hunger-game
  2. See that all insight types are selected
  3. Unselect the type of insight of the question that is currently displayed
  4. Observe that the same question is still displayed

Expected behavior
The current question should not be displayed any more. The insight filter should be applied immediately (possibly throttled to not spam robotoff with questions), so that I don't have to answer questions that I currently don't want to answer.

@alexfauquette
Copy link
Member

@hangy Thanks for reporting this bug, I will look to fix it ;)

@alexfauquette
Copy link
Member

@teolemon The PR liked to this issue is here ;)
openfoodfacts/openfoodfacts-hungergames#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants