-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new localized ProductField's #960
Comments
i would love to work on this issue |
Hi @AffanShaikhsurab! |
I added the fields Here’s an example of the value being returned: The error we’re encountering is: How should we approach resolving this issue? Should we:
I am assuming the issues here please help me to solve the issue |
@AffanShaikhsurab That may be part of the problem: we don't care about specifically French labels, we want multilingual labels. {
"code": "3017620425035",
"product": {
"conservation_conditions_languages": {
"fr": "A conserver au sec et à l'abri de la chaleur. Ne pas mettre au réfrigérateur."
},
"customer_service_languages": {
"fr": "FERRERO FRANCE COMMERCIALE - Service Consommateurs, CS 90058 - 76136 MONT SAINT AIGNAN Cedex"
}
},
"status": 1,
"status_verbose": "product found"
} Please use for conservation conditions and customer service the same logic as for product name, cf. https://fr.openfoodfacts.org/produit/3017620425035/nutella-ferrero.com?fields=conservation_conditions_languages,customer_service_languages,product_name_languages {
"code": "3017620425035",
"product": {
"conservation_conditions_languages": {
"fr": "A conserver au sec et à l'abri de la chaleur. Ne pas mettre au réfrigérateur."
},
"customer_service_languages": {
"fr": "FERRERO FRANCE COMMERCIALE - Service Consommateurs, CS 90058 - 76136 MONT SAINT AIGNAN Cedex"
},
"product_name_languages": {
"de": "Nutella",
"en": "Nutella",
"es": "",
"fr": "Nutella",
"zh": "费列罗榛子巧克力酱"
}
},
"status": 1,
"status_verbose": "product found"
} |
Ohh Soory now I see the issue I will fix it asap |
i have added the customer_service_languages , conservation_conditions_languages properly but when regenerating the product.g.dart using the |
Cool!
Strange, I've never seen that.
As far as the current issue goes, please create a pull request with only the files needed - regardless of whatever failed generating unrelated files. |
After pulling the repository from GitHub, I did not delete any folder named .dart_tool/build. However, I am encountering an error while generating product.g.dart using [INFO] Found 59 declared outputs which already exist on disk. This is likely because the |
Why - Problem description
I've noticed new localized product fields:
conservation_conditions_fr
customer_service_fr
cf. https://fr.openfoodfacts.org/produit/3017620425035/nutella-ferrero.com?fields=conservation_conditions_fr,customer_service_fr
We should implement them as localized fields in
ProductField
andProduct
.The text was updated successfully, but these errors were encountered: