Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No server response" error: to be localized and with reusable URL #836

Closed
monsieurtanuki opened this issue Nov 24, 2023 · 0 comments · Fixed by #837
Closed

"No server response" error: to be localized and with reusable URL #836

monsieurtanuki opened this issue Nov 24, 2023 · 0 comments · Fixed by #837

Comments

@monsieurtanuki
Copy link
Contributor

Why - Problem description

cf. openfoodfacts/smooth-app#4836

  • There are 2 places in the code with 'No response, open an issue here: https://github.com/openfoodfacts/openfoodfacts-dart/issues/new'
  • That is not localized.
  • It's used only as an error String

What - Proposed solution

  • For an app it would make sense to rather set some kind of boolean, which would make it possible
    • to localize the string
    • to use the URL for a "go!" button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Dart package - Support for new APIs and issues
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 836 - localizable and clickable server error monsieurtanuki/openfoodfacts-dart
1 participant
@monsieurtanuki