Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: move Taxonomy methods to a specific file #804

Open
monsieurtanuki opened this issue Sep 11, 2023 · 0 comments
Open

Refactoring: move Taxonomy methods to a specific file #804

monsieurtanuki opened this issue Sep 11, 2023 · 0 comments

Comments

@monsieurtanuki
Copy link
Contributor

Why - Problem description

Our main file open_food_api_client.dart is very big (1291 lines).

What - Proposed solution

If we moved "taxonomy" methods to a specific file, it would go down to 1024 lines. Which is still too big, but it would already be a 20% decrease. And 1024 is 2^10, but I don't think we can maintain that geeky number of lines very long 😉

Additional context

That would be a breaking change.
Perhaps we would need to refactor the methods another way, when integrating obf opf opff (e.g. each with a specific "login" method or a common method?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants