Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test functions and instructions to verify installation #5

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Add test functions and instructions to verify installation #5

merged 1 commit into from
Jan 2, 2020

Conversation

LucasRoesler
Copy link
Member

What

  • Add test publisher and receiver functions and instructions for how to
    use them to test the installations of the nats-connector. This
    should make the installation easier for users.

@alexellis the test functions will need to be built and pushed to the OpenFaaS Docker Hub

Resolves #4

@LucasRoesler
Add test functions and instructions to verify installation
4e5b41b 
**What**
- Add test publisher and receiver functions and instructions for how to
  use them to test the installations of the `nats-connector`. This
  should make the installation easier for users.

Resolves openfaas#4

Signed-off-by: Lucas Roesler <[email protected]>
@alexellis
Copy link
Member

Do you need to commit the vendor folder when using modules?

@LucasRoesler
Copy link
Member Author

@alexellis i left them there because i thought it would be easier than documenting the requirement to use -b GO111MODULE=on during faas-cli build. The stack file doesn't support build args yet you have to pass the build arg to use go modules in the template. That is why i created some new templates for my personal use, but i figured you would not want that included here.

@alexellis
Copy link
Member

Thanks for simplifying the example 👍

Given that the OpenFaaS contributing guide asks for dep still, I was surprised to see go modules used anyway. I guess we can leave it as is.

The user will be running bespoke commands for testing this, so I don't think using --build-arg is a problem.

@alexellis alexellis merged commit fb1e5da into openfaas:master Jan 2, 2020
@alexellis
Copy link
Member

I'm running faas-cli build/push for the images as requested.

@alexellis
Copy link
Member

The images are up now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add example Pod to publish some tester messages
2 participants
@LucasRoesler @alexellis