Skip to content

fix: match video download link font size with transcripts#226

Merged
farhan merged 1 commit intoopenedx:mainfrom
mitodl:marslan/10469-video-xblock-links-font-size
Apr 2, 2026
Merged

fix: match video download link font size with transcripts#226
farhan merged 1 commit intoopenedx:mainfrom
mitodl:marslan/10469-video-xblock-links-font-size

Conversation

@marslanabdulrauf
Copy link
Copy Markdown
Contributor

@marslanabdulrauf marslanabdulrauf commented Apr 1, 2026

Related Ticket

https://github.com/mitodl/hq/issues/10469 (MIT Internal)

Openedx-platform

openedx/openedx-platform#38267

Description

This pull request makes minor adjustments to the CSS styling for video downloads and transcript options to ensure consistency in font size and weight between the video sources and transcript download links.

  • Styling Consistency Updates
    • Set the font size of .video-sources to 16px and unset its font weight to match the transcript options.
    • Commented out the explicit font size setting for transcript option buttons to prevent overriding and maintain consistency with .video-sources.

Testing instructions

Visual difference is clearly visible in Safari browsers, best to test it in Safari

Before

image

After

image

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 1, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Apr 1, 2026

Thanks for the pull request, @marslanabdulrauf!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@marslanabdulrauf marslanabdulrauf force-pushed the marslan/10469-video-xblock-links-font-size branch from 27fe03d to c77149f Compare April 1, 2026 12:31
@marslanabdulrauf marslanabdulrauf marked this pull request as draft April 1, 2026 13:48
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 1, 2026
@FuaadZam FuaadZam moved this to 👀 In review in Aximprovements Team Apr 2, 2026
Copy link
Copy Markdown
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots looks good to me.

Thanks for the contribution

@marslanabdulrauf marslanabdulrauf marked this pull request as ready for review April 2, 2026 10:04
@farhan farhan merged commit 3c41b23 into openedx:main Apr 2, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Aximprovements Team Apr 2, 2026
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Apr 2, 2026
@farhan
Copy link
Copy Markdown
Contributor

farhan commented Apr 2, 2026

Thanks for the contribution ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: ✅ Done
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants