Skip to content

Commit 7dd56d1

Browse files
arbrandesclaude
andcommitted
fix: bin-link frontend-base
npm skips bin-linking on install for workspace packages, so the `openedx` CLI isn't available in node_modules/.bin when needed. Work around this by linking when frontend-base is built. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 2656a69 commit 7dd56d1

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

Makefile

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,23 @@
11
TURBO = TURBO_TELEMETRY_DISABLED=1 turbo --dangerously-disable-package-manager-check
22

3-
.PHONY: build-packages clean-packages clean dev-packages
3+
.PHONY: bin-link build-packages clean-packages clean dev-packages
4+
5+
# NPM doesn't bin-link workspace packages during install, so it must be done manually.
6+
bin-link:
7+
[ -f packages/frontend-base/package.json ] && npm rebuild --ignore-scripts @openedx/frontend-base || true
48

59
build-packages:
610
$(TURBO) run build
11+
$(MAKE) bin-link
712

813
clean-packages:
914
$(TURBO) run clean
1015

1116
dev-packages:
1217
$(TURBO) run watch:build dev:site
1318

19+
dev-site: bin-link
20+
npm run dev
21+
1422
clean:
1523
rm -rf dist

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"build:packages": "make build-packages",
2222
"clean:packages": "make clean-packages",
2323
"dev": "PORT=8080 openedx dev",
24-
"dev:site": "npm run dev",
24+
"dev:site": "make dev-site",
2525
"dev:packages": "make dev-packages",
2626
"clean": "make clean",
2727
"serve": "openedx serve"

0 commit comments

Comments
 (0)