Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed reloading issue #1137

Merged
merged 2 commits into from
Nov 26, 2024
Merged

feat: fixed reloading issue #1137

merged 2 commits into from
Nov 26, 2024

Conversation

sundasnoreen12
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 commented Nov 25, 2024

INF-1594

Description

I resolved an issue that occurred when navigating to the learner profile of a non-existent user. Previously, the user's page would display a perpetual "loading" spinner, but it now correctly displays the content of the "Not Found" page.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After
Before
image

After
Screenshot 2024-11-25 at 5 19 55 PM

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@sundasnoreen12 sundasnoreen12 requested a review from a team as a code owner November 25, 2024 12:20
@sundasnoreen12 sundasnoreen12 changed the base branch from master to 2u-main November 25, 2024 12:25
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.32%. Comparing base (cd73616) to head (e8be5b5).
Report is 6 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/profile/data/sagas.js 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1137      +/-   ##
===========================================
+ Coverage    67.12%   69.32%   +2.19%     
===========================================
  Files           51       72      +21     
  Lines          864     1216     +352     
  Branches       177      269      +92     
===========================================
+ Hits           580      843     +263     
- Misses         274      357      +83     
- Partials        10       16       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sundasnoreen12 sundasnoreen12 changed the title Sundas new/inf 1594 feat: fixed reloading issue Nov 25, 2024
@sundasnoreen12 sundasnoreen12 merged commit 1d0059e into 2u-main Nov 26, 2024
7 of 8 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundasNew/INF-1594 branch November 26, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants