-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixes the auto_advance feature for video XBlock #1426
fix: Fixes the auto_advance feature for video XBlock #1426
Conversation
The commit adds eventlistener which picks up the autoAdvance message and triggers the next sequence. This has the same effect of clicking the next button. Signed-off-by: Farhaan Bukhsh <[email protected]>
Thanks for the pull request, @farhaanbukhsh! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Signed-off-by: Farhaan Bukhsh <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1426 +/- ##
==========================================
- Coverage 88.87% 88.83% -0.04%
==========================================
Files 307 307
Lines 5285 5294 +9
Branches 1310 1314 +4
==========================================
+ Hits 4697 4703 +6
- Misses 572 573 +1
- Partials 16 18 +2 ☔ View full report in Codecov by Sentry. |
@farhaanbukhsh Since it's not clear if/when we'd be able to resume this work, would it make sense to close this PR for now? |
@farhaanbukhsh I'll go ahead and close this PR now. Just reopen if/when you're ready to resume the work. |
Description
We are adding an event listener, which listens to the
autoAdvance
message and triggers the next sequence.Supporting information
This PR works in addition to openedx/edx-platform#35200
Testing instructions
TBD
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.Other information