Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes the auto_advance feature for video XBlock #1426

Conversation

farhaanbukhsh
Copy link
Member

Description

We are adding an event listener, which listens to the autoAdvance message and triggers the next sequence.

Supporting information

This PR works in addition to openedx/edx-platform#35200

Testing instructions

TBD

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

The commit adds eventlistener which picks up the autoAdvance message and
triggers the next sequence. This has the same effect of clicking the
next button.

Signed-off-by: Farhaan Bukhsh <[email protected]>
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 29, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 29, 2024

Thanks for the pull request, @farhaanbukhsh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@farhaanbukhsh farhaanbukhsh marked this pull request as draft July 29, 2024 19:44
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.83%. Comparing base (167d51b) to head (73296d3).
Report is 67 commits behind head on master.

Files with missing lines Patch % Lines
...re/course/sequence/Unit/hooks/useIFrameBehavior.js 66.66% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1426      +/-   ##
==========================================
- Coverage   88.87%   88.83%   -0.04%     
==========================================
  Files         307      307              
  Lines        5285     5294       +9     
  Branches     1310     1314       +4     
==========================================
+ Hits         4697     4703       +6     
- Misses        572      573       +1     
- Partials       16       18       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Aug 8, 2024
@itsjeyd
Copy link

itsjeyd commented Oct 31, 2024

@farhaanbukhsh Since it's not clear if/when we'd be able to resume this work, would it make sense to close this PR for now?

@itsjeyd
Copy link

itsjeyd commented Nov 14, 2024

@farhaanbukhsh I'll go ahead and close this PR now. Just reopen if/when you're ready to resume the work.

@itsjeyd itsjeyd closed this Nov 14, 2024
@itsjeyd itsjeyd added the closed inactivity PR was closed because the author abandoned it label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed inactivity PR was closed because the author abandoned it core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants