-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix dropdown menu in breadcrumbs #1191
fix: Fix dropdown menu in breadcrumbs #1191
Conversation
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #1191 +/- ##
===========================================================
Coverage ? 86.95%
===========================================================
Files ? 253
Lines ? 4371
Branches ? 1108
===========================================================
Hits ? 3801
Misses ? 551
Partials ? 19 ☔ View full report in Codecov by Sentry. |
@Lunyachek Thanks for the changes! I'm marking them as ready for review, but if you'd like to continue working on them some more please let me know. CC @mattcarter @openedx/content-aurora |
@itsjeyd @mattcarter I'm planning to release Palm.4 today. |
@cmltaWt0 Sounds good to me, but if you haven't already, please double-check with @mattcarter via |
21698b4
into
openedx:open-release/palm.master
@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This is backport from this MR #1190
This bug was introduced in the latest versions of Paragon after adding the position: relative parameter to the .pgn__menu-select-popup element. You can find the relevant pull request here: openedx/paragon#1281
I have been in communication with the Paragon team, and they convinced me that this fix is necessary for the Menu component. As a result, we have decided to include this minor fix in the Learning MFE.
Before fix:
2023-09-21.00.41.49.mov
After fix:
2023-09-21.00.38.07.mov