Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix dropdown menu in breadcrumbs #1191

Conversation

Lunyachek
Copy link
Contributor

This is backport from this MR #1190

This bug was introduced in the latest versions of Paragon after adding the position: relative parameter to the .pgn__menu-select-popup element. You can find the relevant pull request here: openedx/paragon#1281

I have been in communication with the Paragon team, and they convinced me that this fix is necessary for the Menu component. As a result, we have decided to include this minor fix in the Learning MFE.

Before fix:

2023-09-21.00.41.49.mov

After fix:

2023-09-21.00.38.07.mov

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 20, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 20, 2023

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (open-release/palm.master@73610bf). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             open-release/palm.master    #1191   +/-   ##
===========================================================
  Coverage                            ?   86.95%           
===========================================================
  Files                               ?      253           
  Lines                               ?     4371           
  Branches                            ?     1108           
===========================================================
  Hits                                ?     3801           
  Misses                              ?      551           
  Partials                            ?       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Oct 10, 2023

@Lunyachek Thanks for the changes! I'm marking them as ready for review, but if you'd like to continue working on them some more please let me know.

CC @mattcarter @openedx/content-aurora

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 10, 2023
@itsjeyd itsjeyd requested a review from mattcarter October 10, 2023 07:50
@itsjeyd itsjeyd added the backport PR backports a change from main to a named release. label Oct 17, 2023
@cmltaWt0
Copy link

@itsjeyd @mattcarter I'm planning to release Palm.4 today.
This PR is merged in master, could I merge it to palm.master to have it in the palm.4?

@itsjeyd
Copy link

itsjeyd commented Nov 17, 2023

@cmltaWt0 Sounds good to me, but if you haven't already, please double-check with @mattcarter via #maintainers-pilot on Slack before hitting the button.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 17, 2023
@hurtstotouchfire hurtstotouchfire merged commit 21698b4 into openedx:open-release/palm.master Nov 21, 2023
5 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Lunyachek Lunyachek deleted the lunyachek/fix/breadcrumbs-dropdown-menu-fix-palm branch December 28, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants