-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: grant audit learners access #1180
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1180 +/- ##
=======================================
Coverage 87.85% 87.85%
=======================================
Files 263 263
Lines 4480 4481 +1
Branches 1132 1132
=======================================
+ Hits 3936 3937 +1
Misses 530 530
Partials 14 14
☔ View full report in Codecov by Sentry. |
@@ -20,15 +20,22 @@ const Chat = ({ | |||
'executive-education', | |||
]; | |||
|
|||
const isVerifiedEnrollmentMode = ( | |||
const AUDIT_MODES = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. My only comment is there may be a mismatch between these modes and those on the backend.
I noticed that a paid-bootcamp
mode is missing from VERIFIED_MODES
. I also noticed that there are three Executive Education modes: paid-executive-education
, unpaid-executive-education
, and executive-education
, and we're missing the paid-executive-education
mode from VERIFIED_MODES
. I don't know if paid-executive-education
and executive-education
resolve to the same mode at some point (e.g. executive-education
), but it's something I noticed.
This isn't an issue for our release right now because of the modes available in the alpha courses, and nothing catastrophic will happen as a result of the mismatch, but I think it's worth taking a quick look at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me take a closer look to make sure it matches up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated VERIFIED_MODES
to include both paid-bootcamp
and paid-executive-education
5146969
to
41084d3
Compare
MST-2130
The learning assistant should be visible to audit learners in courses for which the assistant has been enabled.