Skip to content

Commit de31bc4

Browse files
Merge branch 'glugovgrglib/mobile_offline_availability_ADR' of github.com:raccoongang/edx-platform into glugovgrglib/mobile_offline_availability_ADR
2 parents f118702 + 4fa9291 commit de31bc4

File tree

142 files changed

+3563
-2317
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

142 files changed

+3563
-2317
lines changed

.coveragerc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ omit =
2222
lms/envs/*
2323
lms/djangoapps/*/migrations/*
2424
lms/djangoapps/*/features/*
25-
common/djangoapps/terrain/*
2625
common/djangoapps/*/migrations/*
2726
openedx/core/djangoapps/*/migrations/*
2827
openedx/core/djangoapps/debug/*

.coveragerc-local

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ omit =
2121
lms/envs/*
2222
lms/djangoapps/*/migrations/*
2323
lms/djangoapps/*/features/*
24-
common/djangoapps/terrain/*
2524
common/djangoapps/*/migrations/*
2625
openedx/core/djangoapps/*/migrations/*
2726
openedx/core/djangoapps/debug/*

.github/CODEOWNERS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,3 +58,7 @@ lms/templates/dashboard.html @openedx/ax
5858
# Ensure minimal.yml stays minimal, this could be a team in the future
5959
# but it's just me for now, others can sign up if they care as well.
6060
lms/envs/minimal.yml @feanil
61+
62+
# Ensure that un-necessary changes don't happen to the settings files as we're cleaning them up.
63+
lms/envs/production.py @feanil @kdmccormick
64+
cms/envs/production.py @feanil @kdmccormick

.github/workflows/check_python_dependencies.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,18 @@ jobs:
1414
steps:
1515
- name: Checkout Repository
1616
uses: actions/checkout@v4
17-
17+
1818
- name: Set up Python
1919
uses: actions/setup-python@v5
2020
with:
2121
python-version: ${{ matrix.python-version }}
22-
22+
2323
- name: Install repo-tools
2424
run: pip install edx-repo-tools[find_dependencies]
2525

2626
- name: Install setuptool
27-
run: pip install setuptools
28-
27+
run: pip install setuptools
28+
2929
- name: Run Python script
3030
run: |
3131
find_python_dependencies \
@@ -35,6 +35,5 @@ jobs:
3535
--ignore https://github.com/edx/braze-client \
3636
--ignore https://github.com/edx/edx-name-affirmation \
3737
--ignore https://github.com/mitodl/edx-sga \
38-
--ignore https://github.com/edx/token-utils \
3938
--ignore https://github.com/open-craft/xblock-poll
40-
39+

.github/workflows/publish-ci-docker-image.yml

Whitespace-only changes.

.github/workflows/pylint-checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- module-name: lms-1
1717
path: "lms/djangoapps/badges/ lms/djangoapps/branding/ lms/djangoapps/bulk_email/ lms/djangoapps/bulk_enroll/ lms/djangoapps/bulk_user_retirement/ lms/djangoapps/ccx/ lms/djangoapps/certificates/ lms/djangoapps/commerce/ lms/djangoapps/course_api/ lms/djangoapps/course_blocks/ lms/djangoapps/course_home_api/ lms/djangoapps/course_wiki/ lms/djangoapps/coursewarehistoryextended/ lms/djangoapps/debug/ lms/djangoapps/courseware/ lms/djangoapps/course_goals/ lms/djangoapps/rss_proxy/"
1818
- module-name: lms-2
19-
path: "lms/djangoapps/gating/ lms/djangoapps/grades/ lms/djangoapps/instructor/ lms/djangoapps/instructor_analytics/ lms/djangoapps/discussion/ lms/djangoapps/edxnotes/ lms/djangoapps/email_marketing/ lms/djangoapps/experiments/ lms/djangoapps/instructor_task/ lms/djangoapps/learner_dashboard/ lms/djangoapps/learner_home/ lms/djangoapps/lms_initialization/ lms/djangoapps/lms_xblock/ lms/djangoapps/lti_provider/ lms/djangoapps/mailing/ lms/djangoapps/mobile_api/ lms/djangoapps/monitoring/ lms/djangoapps/ora_staff_grader/ lms/djangoapps/program_enrollments/ lms/djangoapps/rss_proxy lms/djangoapps/static_template_view/ lms/djangoapps/staticbook/ lms/djangoapps/support/ lms/djangoapps/survey/ lms/djangoapps/teams/ lms/djangoapps/tests/ lms/djangoapps/user_tours/ lms/djangoapps/verify_student/ lms/djangoapps/mfe_config_api/ lms/envs/ lms/lib/ lms/tests.py"
19+
path: "lms/djangoapps/gating/ lms/djangoapps/grades/ lms/djangoapps/instructor/ lms/djangoapps/instructor_analytics/ lms/djangoapps/discussion/ lms/djangoapps/edxnotes/ lms/djangoapps/experiments/ lms/djangoapps/instructor_task/ lms/djangoapps/learner_dashboard/ lms/djangoapps/learner_home/ lms/djangoapps/lms_initialization/ lms/djangoapps/lms_xblock/ lms/djangoapps/lti_provider/ lms/djangoapps/mailing/ lms/djangoapps/mobile_api/ lms/djangoapps/monitoring/ lms/djangoapps/ora_staff_grader/ lms/djangoapps/program_enrollments/ lms/djangoapps/rss_proxy lms/djangoapps/static_template_view/ lms/djangoapps/staticbook/ lms/djangoapps/support/ lms/djangoapps/survey/ lms/djangoapps/teams/ lms/djangoapps/tests/ lms/djangoapps/user_tours/ lms/djangoapps/verify_student/ lms/djangoapps/mfe_config_api/ lms/envs/ lms/lib/ lms/tests.py"
2020
- module-name: openedx-1
2121
path: "openedx/core/types/ openedx/core/djangoapps/ace_common/ openedx/core/djangoapps/agreements/ openedx/core/djangoapps/api_admin/ openedx/core/djangoapps/auth_exchange/ openedx/core/djangoapps/bookmarks/ openedx/core/djangoapps/cache_toolbox/ openedx/core/djangoapps/catalog/ openedx/core/djangoapps/ccxcon/ openedx/core/djangoapps/commerce/ openedx/core/djangoapps/common_initialization/ openedx/core/djangoapps/common_views/ openedx/core/djangoapps/config_model_utils/ openedx/core/djangoapps/content/ openedx/core/djangoapps/content_libraries/ openedx/core/djangoapps/content_staging/ openedx/core/djangoapps/contentserver/ openedx/core/djangoapps/cookie_metadata/ openedx/core/djangoapps/cors_csrf/ openedx/core/djangoapps/course_apps/ openedx/core/djangoapps/course_date_signals/ openedx/core/djangoapps/course_groups/ openedx/core/djangoapps/courseware_api/ openedx/core/djangoapps/crawlers/ openedx/core/djangoapps/credentials/ openedx/core/djangoapps/credit/ openedx/core/djangoapps/dark_lang/ openedx/core/djangoapps/debug/ openedx/core/djangoapps/discussions/ openedx/core/djangoapps/django_comment_common/ openedx/core/djangoapps/embargo/ openedx/core/djangoapps/enrollments/ openedx/core/djangoapps/external_user_ids/ openedx/core/djangoapps/zendesk_proxy/ openedx/core/djangolib/ openedx/core/lib/ openedx/core/tests/ openedx/core/djangoapps/course_live/"
2222
- module-name: openedx-2

.github/workflows/unit-test-shards.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
"paths": [
3535
"lms/djangoapps/discussion/",
3636
"lms/djangoapps/edxnotes/",
37-
"lms/djangoapps/email_marketing/",
3837
"lms/djangoapps/experiments/"
3938
]
4039
},

cms/djangoapps/api/v1/views/course_runs.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ class CourseRunViewSet(viewsets.GenericViewSet): # lint-amnesty, pylint: disabl
2323
lookup_value_regex = settings.COURSE_KEY_REGEX
2424
permission_classes = (permissions.IsAdminUser,)
2525
serializer_class = CourseRunSerializer
26+
queryset = []
2627

2728
def get_object(self):
2829
lookup_url_kwarg = self.lookup_url_kwarg or self.lookup_field

cms/djangoapps/contentstore/api/views/course_import.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ class CourseImportView(CourseImportExportViewMixin, GenericAPIView):
106106
# TODO: ARCH-91
107107
# This view is excluded from Swagger doc generation because it
108108
# does not specify a serializer class.
109-
exclude_from_schema = True
109+
swagger_schema = None
110110

111111
@course_author_access_required
112112
def post(self, request, course_key):

cms/djangoapps/contentstore/api/views/course_quality.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import time
44

55
import numpy as np
6-
from edxval.api import get_videos_for_course
6+
from edxval.api import get_course_videos_qset
77
from rest_framework.generics import GenericAPIView
88
from rest_framework.response import Response
99
from scipy import stats
@@ -77,6 +77,11 @@ class CourseQualityView(DeveloperErrorViewMixin, GenericAPIView):
7777
* mode
7878
7979
"""
80+
# TODO: ARCH-91
81+
# This view is excluded from Swagger doc generation because it
82+
# does not specify a serializer class.
83+
swagger_schema = None
84+
8085
@course_author_access_required
8186
def get(self, request, course_key):
8287
"""
@@ -180,13 +185,11 @@ def _units_quality(self, course, request): # lint-amnesty, pylint: disable=miss
180185

181186
def _videos_quality(self, course): # lint-amnesty, pylint: disable=missing-function-docstring
182187
video_blocks_in_course = modulestore().get_items(course.id, qualifiers={'category': 'video'})
183-
videos, __ = get_videos_for_course(course.id)
184-
videos_in_val = list(videos)
185-
video_durations = [video['duration'] for video in videos_in_val]
188+
video_durations = [cv.video.duration for cv in get_course_videos_qset(course.id)]
186189

187190
return dict(
188191
total_number=len(video_blocks_in_course),
189-
num_mobile_encoded=len(videos_in_val),
192+
num_mobile_encoded=len(video_durations),
190193
num_with_val_id=len([v for v in video_blocks_in_course if v.edx_video_id]),
191194
durations=self._stats_dict(video_durations),
192195
)

0 commit comments

Comments
 (0)