From 4eb3ddb823b244ffcc6fdc50a4c3a34f8e7b15e7 Mon Sep 17 00:00:00 2001
From: Mehul0812 <mehul@openeducat.com>
Date: Thu, 14 Nov 2024 18:01:59 +0530
Subject: [PATCH] [18.0][FIX]fixed validation in core

---
 openeducat_core/models/student.py                   | 4 ++--
 openeducat_core/models/subject_registration.py      | 2 +-
 openeducat_core/views/student_course_view.xml       | 2 +-
 openeducat_core/views/student_view.xml              | 8 ++++----
 openeducat_core/views/subject_registration_view.xml | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/openeducat_core/models/student.py b/openeducat_core/models/student.py
index fc0beeefb..e6f4c00ff 100644
--- a/openeducat_core/models/student.py
+++ b/openeducat_core/models/student.py
@@ -32,7 +32,7 @@ class OpStudentCourse(models.Model):
     student_id = fields.Many2one('op.student', 'Student',
                                  ondelete="cascade", tracking=True)
     course_id = fields.Many2one('op.course', 'Course', required=True, tracking=True)
-    batch_id = fields.Many2one('op.batch', 'Batch', required=True, tracking=True)
+    batch_id = fields.Many2one('op.batch', 'Batch', tracking=True)
     roll_number = fields.Char('Roll Number', tracking=True)
     subject_ids = fields.Many2many('op.subject', string='Subjects')
     academic_years_id = fields.Many2one('op.academic.year', 'Academic Year')
@@ -119,7 +119,7 @@ def _onchange_name(self):
     @api.constrains('birth_date')
     def _check_birthdate(self):
         for record in self:
-            if record.birth_date > fields.Date.today():
+            if record.birth_date and record.birth_date > fields.Date.today():
                 raise ValidationError(_(
                     "Birth Date can't be greater than current date!"))
 
diff --git a/openeducat_core/models/subject_registration.py b/openeducat_core/models/subject_registration.py
index f2f72f733..17ed4cc1e 100644
--- a/openeducat_core/models/subject_registration.py
+++ b/openeducat_core/models/subject_registration.py
@@ -33,7 +33,7 @@ class OpSubjectRegistration(models.Model):
                                  tracking=True)
     course_id = fields.Many2one('op.course', 'Course', required=True,
                                 tracking=True)
-    batch_id = fields.Many2one('op.batch', 'Batch', required=True,
+    batch_id = fields.Many2one('op.batch', 'Batch',
                                tracking=True)
     compulsory_subject_ids = fields.Many2many(
         'op.subject', 'subject_compulsory_rel',
diff --git a/openeducat_core/views/student_course_view.xml b/openeducat_core/views/student_course_view.xml
index 50856dafe..6b3e02483 100644
--- a/openeducat_core/views/student_course_view.xml
+++ b/openeducat_core/views/student_course_view.xml
@@ -32,7 +32,7 @@
                         <group>
                             <group>
                                 <field name="student_id"/>
-                                <field name="batch_id" domain="[('course_id', '=', course_id)]"/>
+                                <field name="batch_id" domain="[('course_id', '=', course_id)]" required="1"/>
                                 <field name="academic_years_id"/>
                             </group>
                             <group>
diff --git a/openeducat_core/views/student_view.xml b/openeducat_core/views/student_view.xml
index 1219c78cb..03fa53e61 100644
--- a/openeducat_core/views/student_view.xml
+++ b/openeducat_core/views/student_view.xml
@@ -114,7 +114,7 @@
                                                     <field name="middle_name" placeholder="Middle Name"/>
                                                 </td>
                                                 <td style="padding-right:10px;">
-                                                    <field name="last_name" placeholder="Last Name"/>
+                                                    <field name="last_name" placeholder="Last Name" required="1"/>
                                                 </td>
                                             </tr>
                                         </table>
@@ -127,7 +127,7 @@
                                 <group name="personal_detail">
                                     <group>
                                         <field name="gender" required="1"/>
-                                        <field name="birth_date" required="1"/>
+                                        <field name="birth_date"/>
                                         <label for="type"/>
                                         <div name="div_type">
                                             <field class="oe_inline" name="type"/>
@@ -149,8 +149,8 @@
                                                options="{&quot;always_reload&quot;: True}"/>
                                     </group>
                                     <group>
-                                        <field name="email" required="1"/>
-                                        <field name="mobile" required="1"/>
+                                        <field name="email"/>
+                                        <field name="mobile"/>
                                         <field name="lang"/>
                                         <field name="blood_group"/>
                                         <field name="nationality"/>
diff --git a/openeducat_core/views/subject_registration_view.xml b/openeducat_core/views/subject_registration_view.xml
index 36b6065ca..90b47841e 100644
--- a/openeducat_core/views/subject_registration_view.xml
+++ b/openeducat_core/views/subject_registration_view.xml
@@ -50,7 +50,7 @@
                         <group>
                             <group>
                                 <field name="student_id"/>
-                                <field name="batch_id" domain="[('course_id', '=', course_id)]"/>
+                                <field name="batch_id" domain="[('course_id', '=', course_id)]" required='1'/>
                                 <field name="max_unit_load"/>
                             </group>
                             <group>