Add a GitHub action to perform validation of params.env file
#429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstourac
force-pushed
the
checkParamsEnv
branch
from
d9d4e90 to
4db8c31
Compare
jstourac
requested review from
rkpattnaik780 and
atheo89
and removed request for
dibryant
atheo89
reviewed
Feb 26, 2024
| @@ -0,0 +1,330 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This is a great addition to the notebooks repo!
I tested it locally, works as expected in both cases. 🙂
Matched
....
....
Validation of 'manifests/base/params.env' was successful! Congrats :)
Mismached
Checking format of: 'odh-minimal-notebook-image-n-1=quay.io/opendatahub/workbench-images@sha256:f59aa0090a316878e51dbc89234eb3cee189839120a6ab619936872e966b1d5ae'
Checking metadata for image 'odh-minimal-notebook-image-n-1' with URL 'quay.io/opendatahub/workbench-images@sha256:f59aa0090a316878e51dbc89234eb3cee189839120a6ab619936872e966b1d5ae'
FATA[0000] Error parsing image name "docker://quay.io/opendatahub/workbench-images@sha256:f59aa0090a316878e51dbc89234eb3cee189839120a6ab619936872e966b1d5ae": invalid checksum digest length
Couldn't download image metadata with skopeo tool!
ERROR: Image definition for 'odh-minimal-notebook-image-n-1' isn't okay!
....
....
/LGTM
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
That was fast 😄 thank you! |
jstourac
pushed a commit
to jstourac/notebooks
that referenced
this pull request
Nov 13, 2024
sync `main` branch with upstream opendatahub `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC for #304, comments and opinions welcomed 🙂
The branches may be more formalized via something like #309.
Description
This introduces a script that performs checks againts content of the
params.envfile. It checks its format and referenced images trying to identify eventual wrong references.At the moment it isn't able to determine whether the referred image is the latest and proper one we want to reference, but it should be able to recognize in case we are referring to a wrong type of image.
How Has This Been Tested?
Simply run
./ci/check-params-env.shfrom root dir of your cloned repository to see the code in action. You need to haveskopeoandjqtools installed.Merge criteria: