Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install necessary base OS package to make Knit rendering of R markup to PDF possible #798

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shalberd
Copy link

@shalberd shalberd commented Dec 5, 2024

fixes #794

A coworker pointed me to problems he was having converting R markup code to PDF with RStudio.

Description

install needed OS package

How Has This Been Tested?

I took a recent notebooks R Studio image, built a custom image installing the package with yum, then ran
the new workbench image in ODH and was able to produce the PDF rendered from Rmd markup with Knit, it showed up in a popup window.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from caponetto and harshad16 December 5, 2024 16:15
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

Hi @shalberd. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shalberd
Copy link
Author

shalberd commented Dec 6, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

@shalberd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rstudio-notebook-e2e-tests ca6889b link true /test rstudio-notebook-e2e-tests
ci/prow/images ca6889b link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shalberd
Copy link
Author

shalberd commented Dec 10, 2024

@jiridanek @jstourac @guimou tested with built image quay.io/opendatahub/workbench-images:rstudio-c9s-python-3.9-pr-798

again showing old image behavior vs new pr-797 behavior:

image

Knit to PDF button:

image

Render process leads to error:

processing file: Test2.Rmd                                                                                            
/usr/lib/rstudio-server/bin/quarto/bin/tools/pandoc +RTS -K512m -RTS Test2.knit.md --to latex --from markdown+autolink_bare_uris+tex_math_single_backslash --output Test2.tex --lua-filter /opt/app-root/src/Rpackages/4.3/rmarkdown/rmarkdown/lua/pagebreak.lua --lua-filter /opt/app-root/src/Rpackages/4.3/rmarkdown/rmarkdown/lua/latex-div.lua --embed-resources --standalone --highlight-style tango --pdf-engine pdflatex --variable graphics --variable 'geometry:margin=1in'

output file: Test2.knit.md

! LaTeX Error: File `framed.sty' not found.

! Emergency stop.
<read *>
Error: LaTeX failed to compile Test2.tex. See https://yihui.org/tinytex/r/#debugging for debugging tips. See Test2.log for more info.

changed workbench image to quay.io/opendatahub/workbench-images:rstudio-c9s-python-3.9-pr-798`

Testing with markdown to PDF no longer leads to error, rendering fine.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rendering Rmd Markup to pdf not working
2 participants