-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install necessary base OS package to make Knit rendering of R markup to PDF possible #798
base: main
Are you sure you want to change the base?
install necessary base OS package to make Knit rendering of R markup to PDF possible #798
Conversation
…to PDF work Signed-off-by: shalberd <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @shalberd. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@shalberd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@jiridanek @jstourac @guimou tested with built image again showing old image behavior vs new pr-797 behavior: Knit to PDF button: Render process leads to error:
changed workbench image to quay.io/opendatahub/workbench-images:rstudio-c9s-python-3.9-pr-798` Testing with markdown to PDF no longer leads to error, rendering fine. |
fixes #794
A coworker pointed me to problems he was having converting R markup code to PDF with RStudio.
Description
install needed OS package
How Has This Been Tested?
I took a recent notebooks R Studio image, built a custom image installing the package with yum, then ran
the new workbench image in ODH and was able to produce the PDF rendered from Rmd markup with Knit, it showed up in a popup window.
Merge criteria: