py 311 added grabbing proxy-related env vars from container context a…

…nd setting them in R fix Signed-off-by: shalberd <[email protected]>
opendatahub-io · Dec 5, 2024 · e57eb03 · e57eb03
1 parent 1f79790
commit e57eb03
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/rstudio/c9s-python-3.11/run-rstudio.sh b/rstudio/c9s-python-3.11/run-rstudio.sh
@@ -24,8 +24,8 @@ do
   fi
 done  
 # rstudio terminal cant see environment variables set by the container runtime
-# (which breaks kubectl, to fix this we store the KUBERNETES_* and proxy_related env vars in Renviron.site)
-# proxy_related env vars need to be lowercase by key to work in RStudio
+# (which breaks kubectl, to fix this we store the KUBERNETES_* env vars in Renviron.site)
+# Also, we store proxy-related env vars lowercased by key so RStudio projects work with proxy by default
 env | grep KUBERNETES_ >> /usr/lib64/R/etc/Renviron.site
 env | grep HTTP_PROXY | tr '[:upper:]' '[:lower:]' >> /usr/lib64/R/etc/Renviron.site
 env | grep HTTPS_PROXY | tr '[:upper:]' '[:lower:]' >> /usr/lib64/R/etc/Renviron.site

diff --git a/rstudio/c9s-python-3.9/run-rstudio.sh b/rstudio/c9s-python-3.9/run-rstudio.sh
@@ -24,8 +24,8 @@ do
   fi
 done  
 # rstudio terminal cant see environment variables set by the container runtime
-# (which breaks kubectl, to fix this we store the KUBERNETES_* and proxy_related env vars in Renviron.site)
-# proxy_related env vars need to be lowercase by key to work in RStudio
+# (which breaks kubectl, to fix this we store the KUBERNETES_* env vars in Renviron.site)
+# Also, we store proxy-related env vars lowercased by key so RStudio projects work with proxy by default
 env | grep KUBERNETES_ >> /usr/lib64/R/etc/Renviron.site
 env | grep HTTP_PROXY | tr '[:upper:]' '[:lower:]' >> /usr/lib64/R/etc/Renviron.site
 env | grep HTTPS_PROXY | tr '[:upper:]' '[:lower:]' >> /usr/lib64/R/etc/Renviron.site