[RHOAIEDGE-15] Adding option to fetch from git

[biswassri]

Description

Fixes #57
Added a git-clone task to clone the model repo from a git source. This addition required some model paths to be updated in multiple places.

How Has This Been Tested?

Created a new pipeline run with the changes in my srbiswas-pipeline-dev project and was able to have a successful pipeline run.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[biswassri]

Other options that I've tried:

1. adding curl in one step : but the base image doesn't contain curl in that case
2. using when condition: This field is not supported in the step level in Tekton

Problems with the above changes:

1. Currently passing the git path through a param but the download is dependent on the extension of the file (here it's .pkl). Should we parameterize the file extension also? Is that a good solution?

2. The step that is false, still has a container created. Are we good with that approach?

I'm fairly new to tekton so all suggestions are welcome :)

[LaVLaS]

@biswassri Do these new steps need to be ordered within the main pipeline using runAfter ?

[biswassri]

@biswassri Do these new steps need to be ordered within the main pipeline using runAfter ?

Actually not. We only have one step(as task) added in the main-pipeline and since it's when condition based it's difficult to be order. The tasks following the download model one are ordered as before. The success/execution of this new git-clone-model-repo task can be confirmed by the check-model-and-containerfile-exists hence i've skipped the ordering.

[adelton]

I've finished the review, some additional changes are likely needed.

[LaVLaS]

Updating from an offline conversation: @biswassri will be updating the affected Pipelineruns with the missing parameters

[jackdelahunt]

Some parameter names are camelCase while others are kebab-case should we try make these consistent?

[jackdelahunt]

LGTM 👍

[LaVLaS]

/approve

The build-container workflow worked for me when deploying locally and fetching from S3.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: biswassri, jackdelahunt, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [LaVLaS]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adelton]

This no longer seems to be true -- filed as #174. The README should describe the default behaviour more clearly, and the proper steps to change the default behaviour (switch from S3 to git and vice versa).

[adelton]

Something about the static model_dir path is wrong: #175.