Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter Notebook to train tensorflow-housing model #126

Open
piotrpdev opened this issue Oct 5, 2023 · 2 comments
Open

Add Jupyter Notebook to train tensorflow-housing model #126

piotrpdev opened this issue Oct 5, 2023 · 2 comments
Labels
good first issue Good for newcomers kind/documentation Improvements or additions to documentation kind/enhancement New feature or request priority/normal An issue with the product; fix when possible

Comments

@piotrpdev
Copy link
Member

Description

Whether to include pyenv has been debated, but we already have a working notebook that installs pyenv and miniconda. I think the right approach is for us to include this notebook for now and if there are security concerns/other issues we can change it in the future.

For now, I think we should add instructions on how to use the notebook and tell the user to copy the generated model files to S3, so it can be used in the pipelines. This is a crude approach but is only temporary until #112 #115 are finished.

Note
See #84 for more working examples of notebooks.

A/C

@piotrpdev piotrpdev added good first issue Good for newcomers kind/documentation Improvements or additions to documentation kind/enhancement New feature or request priority/normal An issue with the product; fix when possible labels Oct 5, 2023
@piotrpdev
Copy link
Member Author

@adelton @LaVLaS Thoughts?

@adelton
Copy link
Contributor

adelton commented Oct 5, 2023

Conceptually majority of the pipelines/* content belongs to some generic Open Data Hub demo / tutorial / learning repo, and the Edge PoC should just build on top of that, adding only the Edge-specific bits. Or to put it differently, the Edge PoC should not really be maintaining these bits and models and their documentation, we should just use some generic Open Data Hub ones.

So I wouldn't spend too much effort on making the training part perfect.

One of the reasons is the maintenance liability that comes with having this content, as well as liability of recommending the pyenv approach which may lead people to use old / insecure versions of the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/documentation Improvements or additions to documentation kind/enhancement New feature or request priority/normal An issue with the product; fix when possible
Projects
None yet
Development

No branches or pull requests

2 participants