Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to the Containerfiles #121

Open
piotrpdev opened this issue Oct 4, 2023 · 1 comment
Open

Add labels to the Containerfiles #121

piotrpdev opened this issue Oct 4, 2023 · 1 comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt)

Comments

@piotrpdev
Copy link
Member

Description

One of the Containerfiles we use already has some labels to describe the image:

LABEL org.opencontainers.image.licenses="MIT"
LABEL org.opencontainers.image.title="ab-jq"
LABEL org.opencontainers.image.source="https://github.com/opendatahub-io/ai-edge/blob/main/pipelines/containerfiles/Containerfile.ab-jq"
LABEL org.opencontainers.image.url="https://quay.io/repository/rhoai-edge/ab-jq"

It would be nice to have these for the other ones too.

Here is the OpenContainers Annotations Spec.

A/C

@piotrpdev piotrpdev added good first issue Good for newcomers kind/enhancement New feature or request priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt) labels Oct 4, 2023
@adelton
Copy link
Contributor

adelton commented Oct 6, 2023

Just note that the labels should likely be automatically generated, not static, if the user uses their own Git and Quay repositories.

As for org.opencontainers.image.url, I would argue that link to the image registry is not useful. We might want to set org.opencontainers.image.title and/or org.opencontainers.image.description instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request priority/low An issue with the product that doesn't impact the user much or not at all (ie tech debt)
Projects
None yet
Development

No branches or pull requests

2 participants