Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenCRVS advanced search doesn't allow paginating external API's #147

Open
naftis opened this issue Nov 28, 2023 · 1 comment
Open

OpenCRVS advanced search doesn't allow paginating external API's #147

naftis opened this issue Nov 28, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@naftis
Copy link
Contributor

naftis commented Nov 28, 2023 •
edited
Loading

Currently, our develop branch has a pagination that is based on core's advanced search. This is a mistake, as core doesn't allow paginating external API's. The way we did pagination earlier should work fine. There's 2 ways to fix:

  1. Paginate in dci-crvs-api
  2. Allow paginating external API's in core (I'd prefer this)
@naftis naftis added the bug Something isn't working label Nov 28, 2023
@naftis naftis changed the title Advanced search doesn't allow paginating external API's OpenCRVS advanced search doesn't allow paginating external API's Nov 28, 2023
@naftis
Copy link
Contributor Author

naftis commented Nov 30, 2023

Proposed fix in opencrvs/opencrvs-core#6249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@naftis