Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

GSP xr.dataset has 'data' --> 'power_mw' #447

Closed
Tracked by #393
peterdudfield opened this issue Nov 18, 2021 · 3 comments · Fixed by #449
Closed
Tracked by #393

GSP xr.dataset has 'data' --> 'power_mw' #447

peterdudfield opened this issue Nov 18, 2021 · 3 comments · Fixed by #449
Assignees
@peterdudfield
Labels
enhancement New feature or request

Comments

@peterdudfield
Copy link
Contributor

Detailed Description

Batch data has 'data' as a data var and it should be called power_mw
@peterdudfield peterdudfield added the enhancement New feature or request label Nov 18, 2021
@peterdudfield peterdudfield self-assigned this Nov 18, 2021
@peterdudfield peterdudfield moved this to Todo in Nowcasting Nov 18, 2021
@peterdudfield
Copy link
Contributor Author

peterdudfield commented Nov 18, 2021 •
edited
Loading

https://github.com/openclimatefix/nowcasting_dataset/blob/main/nowcasting_dataset/data_sources/gsp/gsp_model.py#L15
shows it should be 'power_mw'

Why did this not caused a validation error?

@peterdudfield
Copy link
Contributor Author

Moving this up to critical as I think this should be done before new batches are made

@peterdudfield peterdudfield moved this from Todo to In Progress in Nowcasting Nov 18, 2021
@peterdudfield peterdudfield mentioned this issue Nov 18, 2021
Merged
7 tasks
@JackKelly JackKelly mentioned this issue Nov 18, 2021
Closed
34 tasks
@JackKelly
Copy link
Member

I've added this to the list in issue #393 🙂

Repository owner moved this from In Progress to Done in Nowcasting Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@peterdudfield peterdudfield

Labels
enhancement New feature or request
Projects
No open projects
Nowcasting
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue/447 gsp power mw openclimatefix/nowcasting_dataset
2 participants
@JackKelly @peterdudfield