Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Split_data config #426

Open
peterdudfield opened this issue Nov 17, 2021 · 1 comment · Fixed by #445
Open

Split_data config #426

peterdudfield opened this issue Nov 17, 2021 · 1 comment · Fixed by #445
Labels
enhancement New feature or request

Comments

@peterdudfield
Copy link
Contributor

peterdudfield commented Nov 17, 2021 •
edited
Loading

Detailed Description

values where hard coded as part of #390 and #424
Would be good to move

  • train_test_validation_split
  • train_validation_test_datetime_split
    to the config model file

Context

Useful not to hard code things

Possible Implementation

in pydantic model file - here and then loaded here
@peterdudfield peterdudfield added the enhancement New feature or request label Nov 17, 2021
@peterdudfield peterdudfield mentioned this issue Nov 17, 2021
Merged
7 tasks
@JackKelly JackKelly moved this to Todo in NIA: WP2 Nov 17, 2021
@peterdudfield peterdudfield mentioned this issue Nov 18, 2021
Closed
7 tasks
@JackKelly JackKelly mentioned this issue Nov 18, 2021
Merged
8 tasks
@JackKelly JackKelly linked a pull request Nov 18, 2021 that will close this issue
Set n_validation_batches to 0 #445
Merged
8 tasks
Repository owner moved this from Todo to Done in NIA: WP2 Nov 18, 2021
@JackKelly JackKelly reopened this Nov 18, 2021
@JackKelly JackKelly moved this from Done to Todo in NIA: WP2 Nov 18, 2021
@JackKelly
Copy link
Member

oops, sorry, I didn't mean for PR #445 to close this issue!

peterdudfield added a commit that referenced this issue Dec 6, 2021
@peterdudfield
#426
9bda6ba
@kasiaocf kasiaocf removed this from NIA: WP2 Jan 20, 2022
@kasiaocf kasiaocf moved this to Todo in Nowcasting Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Nowcasting
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set n_validation_batches to 0 openclimatefix/nowcasting_dataset
2 participants
@JackKelly @peterdudfield