Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Run validation script at the end of prepare_ml_data.py? #317

Open
Tracked by #393
JackKelly opened this issue Nov 1, 2021 · 2 comments
Open
Tracked by #393

Run validation script at the end of prepare_ml_data.py? #317

JackKelly opened this issue Nov 1, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@JackKelly
Copy link
Member

JackKelly commented Nov 1, 2021

Detailed Description

Maybe we should always validated the on-disk batches?

(Let's wait for PR #300 to be merged before working on this)

@peterdudfield
Copy link
Contributor

The validation script is 'abit' / 'a lot' out of data. Itll need some work to update. The good thing is the Batch validates each data source as we go.

Perhaps a easy cahnge to make, would be to validate the t0_datetimes are in sperate groups for the train, validation and test

@JackKelly
Copy link
Member Author

validate the t0_datetimes are in sperate groups for the train, validation and test

I completely agree! I think I implemented this here: https://github.com/openclimatefix/nowcasting_dataset/blob/main/nowcasting_dataset/dataset/split/split.py#L189

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Todo
Development

No branches or pull requests

2 participants