Fix bug in model property template that was not handling unset properly (#262)

Author: packyg

end_to_end_tests/golden-record-custom/custom_e2e/models/model_with_primitive_additional_properties.py

@@ -31,9 +31,9 @@ def to_dict(self) -> Dict[str, Any]:
     @staticmethod
     def from_dict(src_dict: Dict[str, Any]) -> "ModelWithPrimitiveAdditionalProperties":
         d = src_dict.copy()
-        a_date_holder = UNSET
+        a_date_holder: Union[ModelWithPrimitiveAdditionalPropertiesADateHolder, Unset] = UNSET
         _a_date_holder = d.pop("a_date_holder", UNSET)
-        if _a_date_holder is not None and not isinstance(a_date_holder, Unset):
+        if _a_date_holder is not None and not isinstance(_a_date_holder, Unset):
             a_date_holder = ModelWithPrimitiveAdditionalPropertiesADateHolder.from_dict(
                 cast(Dict[str, Any], _a_date_holder)
             )

end_to_end_tests/golden-record/my_test_api_client/models/model_with_primitive_additional_properties.py

@@ -31,9 +31,9 @@ def to_dict(self) -> Dict[str, Any]:
     @staticmethod
     def from_dict(src_dict: Dict[str, Any]) -> "ModelWithPrimitiveAdditionalProperties":
         d = src_dict.copy()
-        a_date_holder = UNSET
+        a_date_holder: Union[ModelWithPrimitiveAdditionalPropertiesADateHolder, Unset] = UNSET
         _a_date_holder = d.pop("a_date_holder", UNSET)
-        if _a_date_holder is not None and not isinstance(a_date_holder, Unset):
+        if _a_date_holder is not None and not isinstance(_a_date_holder, Unset):
             a_date_holder = ModelWithPrimitiveAdditionalPropertiesADateHolder.from_dict(
                 cast(Dict[str, Any], _a_date_holder)
             )

openapi_python_client/templates/property_templates/model_property.pyi

@@ -7,10 +7,10 @@
 {% elif property.nullable %}
 {{ property.python_name }} = None
 {% else %}
-{{ property.python_name }} = UNSET
+{{ property.python_name }}: {{ property.get_type_string() }} = UNSET
 {% endif %}
 _{{ property.python_name }} = {{source}}
-if _{{ property.python_name }} is not None and not isinstance({{ property.python_name }},  Unset):
+if _{{ property.python_name }} is not None and not isinstance(_{{ property.python_name }},  Unset):
     {{ property.python_name }} = {{ property.reference.class_name }}.from_dict(cast(Dict[str, Any], _{{ property.python_name }}))
 {% endif %}
 {% endmacro %}