You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After introducing minor refactoring in WorkflowRuntimeParameters while developing #1398 one regression slipped in related to WorkflowRuntimeParameters#getParamValueWithUndefinedCheck() where istead of null a defaultValue should be returned.
While running WorkflowRuntimeParametersTest after refactoring was made all tests succeded which proved the test coverage was not sufficient and should be extended. Fortunately other SoftwareHeritageOriginsImporterTest test revealed the problem but it should be indicated closer to the root cause.
The text was updated successfully, but these errors were encountered:
After introducing minor refactoring in
WorkflowRuntimeParameters
while developing #1398 one regression slipped in related toWorkflowRuntimeParameters#getParamValueWithUndefinedCheck()
where istead ofnull
adefaultValue
should be returned.While running
WorkflowRuntimeParametersTest
after refactoring was made all tests succeded which proved the test coverage was not sufficient and should be extended. Fortunately otherSoftwareHeritageOriginsImporterTest
test revealed the problem but it should be indicated closer to the root cause.The text was updated successfully, but these errors were encountered: