Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression introduced in WorkflowRuntimeParameters#getParamValueWithUndefinedCheck() method #1401

Closed
marekhorst opened this issue May 15, 2023 · 0 comments
Assignees

Comments

@marekhorst
Copy link
Member

marekhorst commented May 15, 2023

After introducing minor refactoring in WorkflowRuntimeParameters while developing #1398 one regression slipped in related to WorkflowRuntimeParameters#getParamValueWithUndefinedCheck() where istead of null a defaultValue should be returned.

While running WorkflowRuntimeParametersTest after refactoring was made all tests succeded which proved the test coverage was not sufficient and should be extended. Fortunately other SoftwareHeritageOriginsImporterTest test revealed the problem but it should be indicated closer to the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant