Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove translatable content from product config #259

Open
ghost opened this issue Apr 28, 2021 · 0 comments
Open

Remove translatable content from product config #259

ghost opened this issue Apr 28, 2021 · 0 comments
Labels
enhancement New feature or request P2: soon Pretty important

Comments

@ghost
Copy link

ghost commented Apr 28, 2021

After the initial localization run (yay, now), having the localization in the normal config files is an issue from a few angles:

  • The strings are painful to extract/reintegrate.
  • For the source format, it is decidedly not ideal to keep all translations in the same file, it makes a lot more sense to separate by language, so the individual files can be spread out for translation by different people.
  • Reusing translation strings is hard currently (have not tried entities but that is essentially the only real option for reuse currently).
  • There is no good way of getting an overview of strings that still need to be translated.
  • We already have a translation format for fragments, that works quite well. It would make sense to reuse that (or even use the same files that we also use for fragments, so we can share strings between those two components).

Ultimately, it might actually make sense to handle the product config translations entirely as part of simplify.js, so we don't need to change anything about the build-navigation process.

@ghost ghost added enhancement New feature or request P2: soon Pretty important labels Apr 28, 2021
@ghost ghost changed the title Remove translatable content from Product config Remove translatable content from product config Apr 28, 2021
@ghost ghost mentioned this issue Aug 3, 2021
@ghost ghost mentioned this issue Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2: soon Pretty important
Projects
None yet
Development

No branches or pull requests

0 participants