fix order of tasks to install dependencies first

Author: mcepl

.github/workflows/build.yml

@@ -1,5 +1,10 @@
 name: Tests
 
+# Cancel in-progress runs for the same PR.
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
 on:
   pull_request:
 
@@ -20,106 +25,43 @@ jobs:
             echo "run_tests=true" >> "$GITHUB_OUTPUT"
           else
             git fetch origin $GITHUB_BASE_REF --depth=1
-            # git diff using 2 dots should be enough on GitHub.
-            # See https://github.com/python/core-workflow/issues/373
             git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qvE '(\.rst$|^Doc|^Misc)' && echo "run_tests=true" >> "$GITHUB_OUTPUT" || true
           fi
 
-  check_abi_opensuse:
-    name: 'Check ABI (openSUSE Leap)'
+  opensuse-tests:
+    name: '${{ matrix.name }} (openSUSE Leap)'
     runs-on: ubuntu-latest
     needs: check_source
     if: needs.check_source.outputs.run_tests == 'true'
-    container:
-      image: opensuse/leap:latest
-    steps:
-      - uses: actions/checkout@v4
-      - name: Install Dependencies
-        run: |
-          zypper --non-interactive install --auto-agree-with-licenses \
-            gcc \
-            make \
-            libabigail-tools \
-            libffi-devel \
-            zlib-devel \
-            ncurses-devel \
-            gdbm-devel \
-            sqlite3-devel \
-            tk-devel \
-            readline-devel \
-            xz-devel \
-            bzip2 \
-            openssl
-      - name: Build CPython
-        env:
-          CFLAGS: -g3 -O0
-        run: |
-          # Build Python with the libpython dynamic library
-          ./configure --enable-shared
-          make -j4
-      - name: Check for changes in the ABI
-        run: make check-abidump
 
-  check_generated_files_opensuse:
-    name: 'Check generated files (openSUSE Leap)'
-    runs-on: ubuntu-latest
-    needs: check_source
-    if: needs.check_source.outputs.run_tests == 'true'
+    # Use a specific image version for reproducible builds
     container:
-      image: opensuse/leap:latest
-    steps:
-      - uses: actions/checkout@v4
-      - name: Install Dependencies
-        run: |
-          zypper --non-interactive install --auto-agree-with-licenses \
-            gcc \
-            make \
-            tar \
-            libffi-devel \
-            zlib-devel \
-            ncurses-devel \
-            gdbm-devel \
-            sqlite3-devel \
-            tk-devel \
-            readline-devel \
-            xz-devel \
-            bzip2 \
-            openssl
-      - name: Build CPython
-        run: |
-          ./configure --with-pydebug
-          make -j4 regen-all
-      - name: Check for changes
-        run: |
-          changes=$(git status --porcelain)
-          # Check for changes in regenerated files
-          if ! test -z "$changes"
-          then
-            echo "Generated files not up to date. Perhaps you forgot to run make regen-all ;)"
-            echo "$changes"
-            exit 1
-          fi
-      - name: Check exported libpython symbols
-        run: make smelly
+      image: opensuse/leap:15.5
+
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - name: 'Check ABI'
+            task: 'abi'
+          - name: 'Check Generated Files'
+            task: 'generated-files'
+          - name: 'Build and Test'
+            task: 'build-and-test'
 
-  build_opensuse:
-    name: 'Build and Test (openSUSE Leap)'
-    runs-on: ubuntu-latest # The host runner is still Ubuntu
-    needs: check_source
-    if: needs.check_source.outputs.run_tests == 'true'
-    container:
-      image: opensuse/leap:latest # But steps run inside this container
     env:
       OPENSSL_VER: 1.1.1u
+
     steps:
-    - uses: actions/checkout@v4
-    - name: Install Dependencies
+    - name: Install All Dependencies
       run: |
         zypper --non-interactive install --auto-agree-with-licenses \
+          git \
+          tar \
           gcc \
           make \
-          tar \
           python3 \
+          libabigail-tools \
           xorg-x11-server-Xvfb \
           libffi-devel \
           zlib-devel \
@@ -129,22 +71,63 @@ jobs:
           tk-devel \
           readline-devel \
           xz-devel \
-          bzip2
+          bzip2 \
+          openssl
+
+    - uses: actions/checkout@v4
+
     - name: 'Restore OpenSSL build'
+      if: matrix.task == 'build-and-test'
       id: cache-openssl
       uses: actions/cache@v4
       with:
         path: ./multissl/openssl/${{ env.OPENSSL_VER }}
-        # Updated key to be specific to the OS distribution
         key: opensuse-leap-multissl-openssl-${{ env.OPENSSL_VER }}
+
+    # === Steps for ABI Check ===
+    - name: Build CPython for ABI Check
+      if: matrix.task == 'abi'
+      env:
+        CFLAGS: -g3 -O0
+      run: |
+        ./configure --enable-shared
+        make -j4
+    - name: Check for changes in the ABI
+      if: matrix.task == 'abi'
+      run: make check-abidump
+
+    # === Steps for Generated Files Check ===
+    - name: Build CPython for Generated Files Check
+      if: matrix.task == 'generated-files'
+      run: |
+        ./configure --with-pydebug
+        make -j4 regen-all
+    - name: Check for changes in generated files
+      if: matrix.task == 'generated-files'
+      run: |
+        if ! git diff --quiet; then
+          echo "Generated files are not up to date. Please run 'make regen-all' and commit the changes."
+          git status
+          git diff
+          exit 1
+        fi
+    - name: Check exported libpython symbols
+      if: matrix.task == 'generated-files'
+      run: make smelly
+
+    # === Steps for Full Build and Test ===
     - name: Install OpenSSL
-      if: steps.cache-openssl.outputs.cache-hit != 'true'
+      if: matrix.task == 'build-and-test' && steps.cache-openssl.outputs.cache-hit != 'true'
       run: python3 Tools/ssl/multissltests.py --steps=library --base-directory $PWD/multissl --openssl $OPENSSL_VER --system Linux
     - name: Configure CPython
+      if: matrix.task == 'build-and-test'
       run: ./configure --with-pydebug --with-openssl=$PWD/multissl/openssl/$OPENSSL_VER
     - name: Build CPython
+      if: matrix.task == 'build-and-test'
       run: make -j4
     - name: Display build info
+      if: matrix.task == 'build-and-test'
       run: make pythoninfo
-    - name: Tests
-      run: xvfb-run make buildbottest TESTOPTS="-j4 -uall,-cpu"
+    - name: Run tests
+      if: matrix.task == 'build-and-test'
+      run: xvfb-run make buildbottest TESTOPTS="-j4 -uall,-cpu"